From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: MingChia Chung <quexint@gmail.com>
Cc: gregkh@linuxfoundation.org, shaun.ren@linux.com,
bhaktipriya96@gmail.com, janani.rvchndrn@gmail.com,
bhumirks@gmail.com, dilekuzulmez@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rts5208: rtsx.c: Fix checkpatch warnings.
Date: Mon, 22 Aug 2016 22:51:27 +0530 [thread overview]
Message-ID: <20160822172127.GA29160@sudip-laptop> (raw)
In-Reply-To: <20160822165417.GA39631@Qsphere.local>
On Tue, Aug 23, 2016 at 12:54:17AM +0800, MingChia Chung wrote:
> This patch fixes a minor checkpatch warnings:
>
> "WARNING: Block comments use a trailing */ on a separate line"
>
> Signed-off-by: Ming-Chia Chung <Quexint@gmail.com>
> ---
> drivers/staging/rts5208/rtsx.c | 42 ++++++++++++++++++++++++++++--------------
> 1 file changed, 28 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
> index e992e03..a880411 100644
> --- a/drivers/staging/rts5208/rtsx.c
> +++ b/drivers/staging/rts5208/rtsx.c
> @@ -81,14 +81,16 @@ static int slave_alloc(struct scsi_device *sdev)
>
> static int slave_configure(struct scsi_device *sdev)
> {
> - /* Scatter-gather buffers (all but the last) must have a length
> + /*
> + * Scatter-gather buffers (all but the last) must have a length
The alignment doesnot look correct here. Also in some more places later
in this patch.
regards
Sudip
next prev parent reply other threads:[~2016-08-22 17:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 16:54 [PATCH] staging: rts5208: rtsx.c: Fix checkpatch warnings MingChia Chung
2016-08-22 17:21 ` Sudip Mukherjee [this message]
2016-08-23 0:19 ` Ming-Chia Chung
2016-08-23 6:31 ` Sudip Mukherjee
2016-08-25 13:59 ` Ming-Chia Chung
2016-08-25 16:50 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160822172127.GA29160@sudip-laptop \
--to=sudipm.mukherjee@gmail.com \
--cc=bhaktipriya96@gmail.com \
--cc=bhumirks@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=dilekuzulmez@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=janani.rvchndrn@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=quexint@gmail.com \
--cc=shaun.ren@linux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox