From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754922AbcHVSxY (ORCPT ); Mon, 22 Aug 2016 14:53:24 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:42240 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752158AbcHVSxX (ORCPT ); Mon, 22 Aug 2016 14:53:23 -0400 Date: Mon, 22 Aug 2016 14:52:58 -0400 From: Sowmini Varadhan To: Mikko Rapeli Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH v05 08/72] rds.h: use __u8, __u16, __s16, __u32 and __s64 from linux/types.h Message-ID: <20160822185258.GD25521@oracle.com> References: <1471890809-4383-1-git-send-email-mikko.rapeli@iki.fi> <1471890809-4383-9-git-send-email-mikko.rapeli@iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1471890809-4383-9-git-send-email-mikko.rapeli@iki.fi> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (08/22/16 20:32), Mikko Rapeli wrote: > > Fixes userspace compilation errors like: > > linux/rds.h:96:2: error: unknown type name ‘uint8_t’ > > Signed-off-by: Mikko Rapeli Acked-by: Sowmini Varadhan I think we discussed this some time before, and I certainly dont have any religious opinions about it, but I would like to point out that this means that the exported rds.h will expose __ to user space applications. --Sowmini