From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932702AbcHVVUk (ORCPT ); Mon, 22 Aug 2016 17:20:40 -0400 Received: from mail-pa0-f65.google.com ([209.85.220.65]:35466 "EHLO mail-pa0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756703AbcHVVUg (ORCPT ); Mon, 22 Aug 2016 17:20:36 -0400 Date: Mon, 22 Aug 2016 14:20:06 -0700 From: Dmitry Torokhov To: Masahiro Yamada Cc: linux-input@vger.kernel.org, Thierry Reding , linux-kernel@vger.kernel.org, Stephen Warren , Rakesh Iyer , Laxman Dewangan , linux-tegra@vger.kernel.org, Alexandre Courbot Subject: Re: [PATCH] Input: tegra-kbc: fix inverted reset logic Message-ID: <20160822212006.GF12277@dtor-ws> References: <1471316363-19378-1-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1471316363-19378-1-git-send-email-yamada.masahiro@socionext.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 16, 2016 at 11:59:23AM +0900, Masahiro Yamada wrote: > Commit fe6b0dfaba68 ("Input: tegra-kbc - use reset framework") > accidentally converted _deassert to _assert, so there is no code > to wake up this hardware. > > Fixes: fe6b0dfaba68 ("Input: tegra-kbc - use reset framework") > Signed-off-by: Masahiro Yamada Applied, thank you. > --- > > drivers/input/keyboard/tegra-kbc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c > index 7d61439..0c07e10 100644 > --- a/drivers/input/keyboard/tegra-kbc.c > +++ b/drivers/input/keyboard/tegra-kbc.c > @@ -376,7 +376,7 @@ static int tegra_kbc_start(struct tegra_kbc *kbc) > /* Reset the KBC controller to clear all previous status.*/ > reset_control_assert(kbc->rst); > udelay(100); > - reset_control_assert(kbc->rst); > + reset_control_deassert(kbc->rst); > udelay(100); > > tegra_kbc_config_pins(kbc); > -- > 1.9.1 > -- Dmitry