[PATCH 0/2] staging: vt6655: fix checkpatch warning for trailing */ on a separate line

public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed

* [PATCH 0/2] staging: vt6655: fix checkpatch warning for trailing */ on a separate line
@ 2016-08-22 16:54 Anson Jacob
  2016-08-22 16:54 ` [PATCH 1/2] staging: vt6655: rf.c: Fix checkpatch warning Anson Jacob
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Anson Jacob @ 2016-08-22 16:54 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Forest Bond; +Cc: linux-kernel, devel

*** BLURB HERE ***

Anson Jacob (2):
  staging: vt6655: rf.c: Fix checkpatch warning
  staging: vt6655: rxtx.c: Fix checkpatch warning

 drivers/staging/vt6655/rf.c   | 19 ++++++++++++-------
 drivers/staging/vt6655/rxtx.c | 41 ++++++++++++++++++++++++-----------------
 2 files changed, 36 insertions(+), 24 deletions(-)

-- 
2.7.4

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/2] staging: vt6655: rf.c: Fix checkpatch warning
  2016-08-22 16:54 [PATCH 0/2] staging: vt6655: fix checkpatch warning for trailing */ on a separate line Anson Jacob
@ 2016-08-22 16:54 ` Anson Jacob
  2016-08-22 16:55 ` [PATCH 2/2] staging: vt6655: rxtx.c: " Anson Jacob
  2016-08-22 20:36 ` [PATCH 0/2] staging: vt6655: fix checkpatch warning for trailing */ on a separate line Greg Kroah-Hartman
  2 siblings, 0 replies; 5+ messages in thread
From: Anson Jacob @ 2016-08-22 16:54 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Forest Bond; +Cc: linux-kernel, devel

Fix checkpatch.pl warning for trailing */ on a separate line
Remove '+' postfix and '-' prefix from the start and end of block comments

Signed-off-by: Anson Jacob <ansonjacob.aj@gmail.com>
---
 drivers/staging/vt6655/rf.c | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/vt6655/rf.c b/drivers/staging/vt6655/rf.c
index ae10da2..447882c 100644
--- a/drivers/staging/vt6655/rf.c
+++ b/drivers/staging/vt6655/rf.c
@@ -169,7 +169,8 @@ static unsigned long dwAL2230PowerTable[AL2230_PWR_IDX_LEN] = {
 };
 
 /* 40MHz reference frequency
- * Need to Pull PLLON(PE3) low when writing channel registers through 3-wire.*/
+ * Need to Pull PLLON(PE3) low when writing channel registers through 3-wire.
+ */
 static const unsigned long dwAL7230InitTable[CB_AL7230_INIT_SEQ] = {
 	0x00379000+(BY_AL7230_REG_LEN<<3)+IFREGCTL_REGW, /* Channel1 // Need modify for 11a */
 	0x13333100+(BY_AL7230_REG_LEN<<3)+IFREGCTL_REGW, /* Channel1 // Need modify for 11a */
@@ -463,7 +464,8 @@ static bool s_bAL7230Init(struct vnt_private *priv)
 }
 
 /* Need to Pull PLLON low when writing channel registers through
- * 3-wire interface */
+ * 3-wire interface
+ */
 static bool s_bAL7230SelectChannel(struct vnt_private *priv, unsigned char byChannel)
 {
 	void __iomem *dwIoBase = priv->PortOffset;
@@ -873,7 +875,8 @@ bool RFbRawSetPower(
 
 	case RF_AIROHA7230:
 		/* 0x080F1B00 for 3 wire control TxGain(D10)
-		 * and 0x31 as TX Gain value */
+		 * and 0x31 as TX Gain value
+		 */
 		dwMax7230Pwr = 0x080C0B00 | ((byPwr) << 12) |
 			(BY_AL7230_REG_LEN << 3)  | IFREGCTL_REGW;
 
@@ -886,7 +889,7 @@ bool RFbRawSetPower(
 	return ret;
 }
 
-/*+
+/*
  *
  * Routine Description:
  *     Translate RSSI to dBm
@@ -900,7 +903,7 @@ bool RFbRawSetPower(
  *
  * Return Value: none
  *
- -*/
+ */
 void
 RFvRSSITodBm(
 	struct vnt_private *priv,
@@ -927,7 +930,8 @@ RFvRSSITodBm(
 }
 
 /* Post processing for the 11b/g and 11a.
- * for save time on changing Reg2,3,5,7,10,12,15 */
+ * for save time on changing Reg2,3,5,7,10,12,15
+ */
 bool RFbAL7230SelectChannelPostProcess(struct vnt_private *priv,
 				       u16 byOldChannel,
 				       u16 byNewChannel)
@@ -938,7 +942,8 @@ bool RFbAL7230SelectChannelPostProcess(struct vnt_private *priv,
 
 	/* if change between 11 b/g and 11a need to update the following
 	 * register
-	 * Channel Index 1~14 */
+	 * Channel Index 1~14
+	 */
 	if ((byOldChannel <= CB_MAX_CHANNEL_24G) && (byNewChannel > CB_MAX_CHANNEL_24G)) {
 		/* Change from 2.4G to 5G [Reg] */
 		ret &= IFRFbWriteEmbedded(priv, dwAL7230InitTableAMode[2]);
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] staging: vt6655: rxtx.c: Fix checkpatch warning
  2016-08-22 16:54 [PATCH 0/2] staging: vt6655: fix checkpatch warning for trailing */ on a separate line Anson Jacob
  2016-08-22 16:54 ` [PATCH 1/2] staging: vt6655: rf.c: Fix checkpatch warning Anson Jacob
@ 2016-08-22 16:55 ` Anson Jacob
  2016-08-22 20:36 ` [PATCH 0/2] staging: vt6655: fix checkpatch warning for trailing */ on a separate line Greg Kroah-Hartman
  2 siblings, 0 replies; 5+ messages in thread
From: Anson Jacob @ 2016-08-22 16:55 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Forest Bond; +Cc: linux-kernel, devel

Fix checkpatch.pl warning for trailing */ on a separate line
Remove '+' postfix and '-' prefix from the start and end of block comments

Signed-off-by: Anson Jacob <ansonjacob.aj@gmail.com>
---
 drivers/staging/vt6655/rxtx.c | 41 ++++++++++++++++++++++++-----------------
 1 file changed, 24 insertions(+), 17 deletions(-)

diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
index e4c3165..890d108 100644
--- a/drivers/staging/vt6655/rxtx.c
+++ b/drivers/staging/vt6655/rxtx.c
@@ -64,8 +64,10 @@
 /*---------------------  Static Functions  --------------------------*/
 
 /*---------------------  Static Definitions -------------------------*/
-#define CRITICAL_PACKET_LEN      256    /* if packet size < 256 -> in-direct send
-                                            packet size >= 256 -> direct send */
+/* if packet size < 256 -> in-direct send
+ * vpacket size >= 256 -> direct send
+ */
+#define CRITICAL_PACKET_LEN      256
 
 static const unsigned short wTimeStampOff[2][MAX_RATE] = {
 	{384, 288, 226, 209, 54, 43, 37, 31, 28, 25, 24, 23}, /* Long Preamble */
@@ -158,11 +160,11 @@ static __le16 vnt_time_stamp_off(struct vnt_private *priv, u16 rate)
 							[rate % MAX_RATE]);
 }
 
-/*byPktType : PK_TYPE_11A     0
-  PK_TYPE_11B     1
-  PK_TYPE_11GB    2
-  PK_TYPE_11GA    3
-*/
+/* byPktType : PK_TYPE_11A     0
+ * PK_TYPE_11B     1
+ * PK_TYPE_11GB    2
+ * PK_TYPE_11GA    3
+ */
 static
 unsigned int
 s_uGetTxRsvTime(
@@ -650,13 +652,16 @@ s_vFillRTSHead(
 		return;
 
 	if (bDisCRC) {
-		/* When CRCDIS bit is on, H/W forgot to generate FCS for RTS frame,
-		 in this case we need to decrease its length by 4. */
+		/* When CRCDIS bit is on, H/W forgot to generate FCS for
+		 * RTS frame, in this case we need to decrease its length by 4.
+		 */
 		uRTSFrameLen -= 4;
 	}
 
-	/* Note: So far RTSHead doesn't appear in ATIM & Beacom DMA, so we don't need to take them into account.
-	       Otherwise, we need to modify codes for them. */
+	/* Note: So far RTSHead doesn't appear in ATIM & Beacom DMA,
+	 * so we don't need to take them into account.
+	 * Otherwise, we need to modify codes for them.
+	 */
 	if (byPktType == PK_TYPE_11GB || byPktType == PK_TYPE_11GA) {
 		if (byFBOption == AUTO_FB_NONE) {
 			struct vnt_rts_g *buf = pvRTS;
@@ -842,8 +847,9 @@ s_vFillCTSHead(
 		return;
 
 	if (bDisCRC) {
-		/* When CRCDIS bit is on, H/W forgot to generate FCS for CTS frame,
-		 in this case we need to decrease its length by 4. */
+		/* When CRCDIS bit is on, H/W forgot to generate FCS for
+		 * CTS frame, in this case we need to decrease its length by 4.
+		 */
 		uCTSFrameLen -= 4;
 	}
 
@@ -915,7 +921,7 @@ s_vFillCTSHead(
 	}
 }
 
-/*+
+/*
  *
  * Description:
  *      Generate FIFO control for MAC & Baseband controller
@@ -937,7 +943,8 @@ s_vFillCTSHead(
  * Return Value: none
  *
  -
- * unsigned int cbFrameSize, Hdr+Payload+FCS */
+ * unsigned int cbFrameSize, Hdr+Payload+FCS
+ */
 static
 void
 s_vGenerateTxParameter(
@@ -972,8 +979,8 @@ s_vGenerateTxParameter(
 		return;
 
 	if (byPktType == PK_TYPE_11GB || byPktType == PK_TYPE_11GA) {
-		if (pvRTS != NULL) { /* RTS_need
-			 Fill RsvTime */
+		if (pvRTS != NULL) { /* RTS_need */
+			/* Fill RsvTime */
 			struct vnt_rrv_time_rts *buf = pvRrvTime;
 
 			buf->rts_rrv_time_aa = s_uGetRTSCTSRsvTime(pDevice, 2, byPktType, cbFrameSize, wCurrentRate);
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/2] staging: vt6655: fix checkpatch warning for trailing */ on a separate line
  2016-08-22 16:54 [PATCH 0/2] staging: vt6655: fix checkpatch warning for trailing */ on a separate line Anson Jacob
  2016-08-22 16:54 ` [PATCH 1/2] staging: vt6655: rf.c: Fix checkpatch warning Anson Jacob
  2016-08-22 16:55 ` [PATCH 2/2] staging: vt6655: rxtx.c: " Anson Jacob
@ 2016-08-22 20:36 ` Greg Kroah-Hartman
  2016-08-22 21:23   ` Anson Jacob
  2 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2016-08-22 20:36 UTC (permalink / raw)
  To: Anson Jacob; +Cc: Forest Bond, devel, linux-kernel

On Mon, Aug 22, 2016 at 12:54:12PM -0400, Anson Jacob wrote:
> *** BLURB HERE ***

You forgot the blurb :)

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/2] staging: vt6655: fix checkpatch warning for trailing */ on a separate line
  2016-08-22 20:36 ` [PATCH 0/2] staging: vt6655: fix checkpatch warning for trailing */ on a separate line Greg Kroah-Hartman
@ 2016-08-22 21:23   ` Anson Jacob
  0 siblings, 0 replies; 5+ messages in thread
From: Anson Jacob @ 2016-08-22 21:23 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: Forest Bond, devel, linux-kernel

On Mon, Aug 22, 2016 at 04:36:26PM -0400, Greg Kroah-Hartman wrote:
> On Mon, Aug 22, 2016 at 12:54:12PM -0400, Anson Jacob wrote:
> > *** BLURB HERE ***
> 
> You forgot the blurb :)
> 
Sorry about that. Uploaded a new patchset with blurb :)

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-08-22 21:25 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-22 16:54 [PATCH 0/2] staging: vt6655: fix checkpatch warning for trailing */ on a separate line Anson Jacob
2016-08-22 16:54 ` [PATCH 1/2] staging: vt6655: rf.c: Fix checkpatch warning Anson Jacob
2016-08-22 16:55 ` [PATCH 2/2] staging: vt6655: rxtx.c: " Anson Jacob
2016-08-22 20:36 ` [PATCH 0/2] staging: vt6655: fix checkpatch warning for trailing */ on a separate line Greg Kroah-Hartman
2016-08-22 21:23   ` Anson Jacob

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox