From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757362AbcHWAUM (ORCPT ); Mon, 22 Aug 2016 20:20:12 -0400 Received: from mail-pa0-f66.google.com ([209.85.220.66]:36393 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755982AbcHWAUL (ORCPT ); Mon, 22 Aug 2016 20:20:11 -0400 From: Ming-Chia Chung X-Google-Original-From: Ming-Chia Chung Date: Tue, 23 Aug 2016 08:19:46 +0800 To: Sudip Mukherjee Cc: gregkh@linuxfoundation.org, shaun.ren@linux.com, bhaktipriya96@gmail.com, janani.rvchndrn@gmail.com, bhumirks@gmail.com, dilekuzulmez@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rts5208: rtsx.c: Fix checkpatch warnings. Message-ID: <20160823001946.GA78290@Qsphere.local> References: <20160822165417.GA39631@Qsphere.local> <20160822172127.GA29160@sudip-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160822172127.GA29160@sudip-laptop> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 22, 2016 at 10:51:27PM +0530, Sudip Mukherjee wrote: > On Tue, Aug 23, 2016 at 12:54:17AM +0800, MingChia Chung wrote: > > This patch fixes a minor checkpatch warnings: > > > > "WARNING: Block comments use a trailing */ on a separate line" > > > > Signed-off-by: Ming-Chia Chung > > --- > > drivers/staging/rts5208/rtsx.c | 42 ++++++++++++++++++++++++++++-------------- > > 1 file changed, 28 insertions(+), 14 deletions(-) > > > > diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c > > index e992e03..a880411 100644 > > --- a/drivers/staging/rts5208/rtsx.c > > +++ b/drivers/staging/rts5208/rtsx.c > > @@ -81,14 +81,16 @@ static int slave_alloc(struct scsi_device *sdev) > > > > static int slave_configure(struct scsi_device *sdev) > > { > > - /* Scatter-gather buffers (all but the last) must have a length > > + /* > > + * Scatter-gather buffers (all but the last) must have a length > > The alignment doesnot look correct here. Also in some more places later > in this patch. > > regards > Sudip I sent this patch by following docs ([1] and [2]). The style for long comments needs the begining and ending almost-blank lines. There is no the begining almost-blank line only for the files in net/ and drivers/net/. Please let me know what I misunderstood. [1]: Linux kernel coding style, ch. 8 Commenting https://www.kernel.org/doc/Documentation/CodingStyle [2]: Linus Torvalds on comment styles https://lkml.org/lkml/2016/7/8/625 regards, MingChia