From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756165AbcHWMLx (ORCPT ); Tue, 23 Aug 2016 08:11:53 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:36753 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753295AbcHWMLv (ORCPT ); Tue, 23 Aug 2016 08:11:51 -0400 Date: Tue, 23 Aug 2016 10:15:30 +0200 From: Johan Hovold To: Mathieu OTHACEHE Cc: johan@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v2 06/22] usb: serial: ti_usb_3410_5052: Remove unused variables Message-ID: <20160823081530.GE16896@localhost> References: <20160726180002.2398-1-m.othacehe@gmail.com> <20160726180002.2398-7-m.othacehe@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160726180002.2398-7-m.othacehe@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 26, 2016 at 07:59:46PM +0200, Mathieu OTHACEHE wrote: > Remove variables affected but never read. This commit message is also incomplete. The tp_flags variable was indeed read, even if it was always ANDed with 0. I applied it anyway this time, and also dropped the now unused TI_SET_SERIAL_FLAGS define that you did remove in v1. > Signed-off-by: Mathieu OTHACEHE Thanks, Johan