Re: [PATCH 1/2] pinctrl: sunxi: fix uart1 CTS/RTS pins at PG on A23/A33

Re: [PATCH 1/2] pinctrl: sunxi: fix uart1 CTS/RTS pins at PG on A23/A33

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 528 bytes --]

Hi,

On Tue, Aug 23, 2016 at 01:58:25PM +0800, Icenowy Zheng wrote:
> PG8, PG9 is said to be the CTS/RTS pins for UART1 according to the A23/33
> datasheets. However, the function is wrongly named "uart2" in the pinctrl
> driver. This patch fixes this by modifying them to be named "uart1".
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>

This looks good, but could you send it to stable?

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 1/2] pinctrl: sunxi: fix uart1 CTS/RTS pins at PG on A23/A33

[Linus Walleij]

On Tue, Aug 23, 2016 at 8:47 AM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> On Tue, Aug 23, 2016 at 01:58:25PM +0800, Icenowy Zheng wrote:
>> PG8, PG9 is said to be the CTS/RTS pins for UART1 according to the A23/33
>> datasheets. However, the function is wrongly named "uart2" in the pinctrl
>> driver. This patch fixes this by modifying them to be named "uart1".
>>
>> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
>
> This looks good, but could you send it to stable?

If that is an ACK I can tag it for stable when applying.

Yours,
Linus Walleij

Re: [PATCH 1/2] pinctrl: sunxi: fix uart1 CTS/RTS pins at PG on A23/A33

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 787 bytes --]

On Tue, Aug 23, 2016 at 11:27:10AM +0200, Linus Walleij wrote:
> On Tue, Aug 23, 2016 at 8:47 AM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > On Tue, Aug 23, 2016 at 01:58:25PM +0800, Icenowy Zheng wrote:
> >> PG8, PG9 is said to be the CTS/RTS pins for UART1 according to the A23/33
> >> datasheets. However, the function is wrongly named "uart2" in the pinctrl
> >> driver. This patch fixes this by modifying them to be named "uart1".
> >>
> >> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> >
> > This looks good, but could you send it to stable?
> 
> If that is an ACK I can tag it for stable when applying.

Yes, it's an ACK. Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 1/2] pinctrl: sunxi: fix uart1 CTS/RTS pins at PG on A23/A33

[Linus Walleij]

On Tue, Aug 23, 2016 at 7:58 AM, Icenowy Zheng <icenowy@aosc.xyz> wrote:

> PG8, PG9 is said to be the CTS/RTS pins for UART1 according to the A23/33
> datasheets. However, the function is wrongly named "uart2" in the pinctrl
> driver. This patch fixes this by modifying them to be named "uart1".
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>

Applied for stable with Maxime's ACK.

Yours,
Linus Walleij

Re: [PATCH 2/2] ARM: dts: sun8i: Add extra UART pinmux settings for A23/33

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 755 bytes --]

Hi,

On Tue, Aug 23, 2016 at 01:58:26PM +0800, Icenowy Zheng wrote:
> A23/33 have 4 UART controllers outside PRCM. However, the devicetree used
> to mentioned only UART0's pinmux settings. Some extra UART controllers have
> RTS/CTS, and is suitable for using as bluetooth UART controller.
> 
> Add the pinmux settings for the UART controller, to make use of the
> bluetooth function of some tablets.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>

Our policy is that we avoid adding unused pinctrl nodes to not cripple
the DT for no particular reason.

So please add only the nodes you'll need in your tablet.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 2/2] ARM: dts: sun8i: Add extra UART pinmux settings for A23/33

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]

Hi,

On Tue, Aug 23, 2016 at 09:51:05PM +0800, Icenowy Zheng wrote:
> 
> 
> 23.08.2016, 19:42, "Maxime Ripard" <maxime.ripard@free-electrons.com>:
> > Hi,
> >
> > On Tue, Aug 23, 2016 at 01:58:26PM +0800, Icenowy Zheng wrote:
> >>  A23/33 have 4 UART controllers outside PRCM. However, the devicetree used
> >>  to mentioned only UART0's pinmux settings. Some extra UART controllers have
> >>  RTS/CTS, and is suitable for using as bluetooth UART controller.
> >>
> >>  Add the pinmux settings for the UART controller, to make use of the
> >>  bluetooth function of some tablets.
> >>
> >>  Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> >
> > Our policy is that we avoid adding unused pinctrl nodes to not cripple
> > the DT for no particular reason.
> >
> > So please add only the nodes you'll need in your tablet.
> 
> Then... if what I needs is the PG group of uart1, should I name it as
> uart1_pins_a or uart1_pins_b?

We don't have any rules here, whichever comes first wins.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]