From: Oleg Nesterov <oleg@redhat.com>
To: Mateusz Guzik <mguzik@redhat.com>
Cc: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
Richard Guy Briggs <rgb@redhat.com>,
ebiederm@xmission.com, sgrubb@redhat.com, pmoore@redhat.com,
eparis@redhat.com, luto@amacapital.net, linux-audit@redhat.com,
linux-kernel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCHv2 1/2] mm: introduce get_task_exe_file
Date: Tue, 23 Aug 2016 16:48:13 +0200 [thread overview]
Message-ID: <20160823144812.GA2088@redhat.com> (raw)
In-Reply-To: <1471962039-14940-2-git-send-email-mguzik@redhat.com>
On 08/23, Mateusz Guzik wrote:
>
> +struct file *get_task_exe_file(struct task_struct *task)
> +{
> + struct file *exe_file = NULL;
> + struct mm_struct *mm;
> +
> + task_lock(task);
> + mm = task->mm;
> + if (mm) {
> + if (!(task->flags & PF_KTHREAD))
> + exe_file = get_mm_exe_file(mm);
> + }
> + task_unlock(task);
> + return exe_file;
> +}
I can't believe I am going to comment the coding style but I can't resist ;)
if (mm && !(task->flags & PF_KTHREAD)))
exe_file = get_mm_exe_file(mm);
looks a bit simpler to me. But this is purely cosmetic and subjective,
both patches look good to me.
Acked-by: Oleg Nesterov <oleg@redhat.com>
next prev parent reply other threads:[~2016-08-23 14:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 14:20 [PATCHv2 0/2] introduce get_task_exe_file and use it to fix audit_exe_compare Mateusz Guzik
2016-08-23 14:20 ` [PATCHv2 1/2] mm: introduce get_task_exe_file Mateusz Guzik
2016-08-23 14:48 ` Oleg Nesterov [this message]
2016-08-23 14:52 ` Mateusz Guzik
2016-08-23 14:20 ` [PATCHv2 2/2] audit: fix exe_file access in audit_exe_compare Mateusz Guzik
2016-08-29 22:50 ` [PATCHv2 0/2] introduce get_task_exe_file and use it to fix audit_exe_compare Paul Moore
2016-08-31 20:22 ` Paul Moore
2016-08-30 18:50 ` Richard Guy Briggs
2016-08-30 20:13 ` Mateusz Guzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160823144812.GA2088@redhat.com \
--to=oleg@redhat.com \
--cc=ebiederm@xmission.com \
--cc=eparis@redhat.com \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mguzik@redhat.com \
--cc=pmoore@redhat.com \
--cc=rgb@redhat.com \
--cc=sgrubb@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox