From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753340AbcHWRtF (ORCPT ); Tue, 23 Aug 2016 13:49:05 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:32915 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751465AbcHWRtB (ORCPT ); Tue, 23 Aug 2016 13:49:01 -0400 Date: Tue, 23 Aug 2016 12:48:41 -0500 From: Rob Herring To: Nishanth Menon Cc: Russell King , Sudeep Holla , Santosh Shilimkar , Russ Dill , Dave Gerlach , Lokesh Vutla , Peter Ujfalusi , "Andrew F . Davis" , Suman Anna , Tero Kristo , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 5/5] firmware: ti_sci: Add support for reboot core service Message-ID: <20160823174841.GA23677@rob-hp-laptop> References: <20160819225159.10758-1-nm@ti.com> <20160819225159.10758-6-nm@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160819225159.10758-6-nm@ti.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 19, 2016 at 05:51:59PM -0500, Nishanth Menon wrote: > Since system controller now has control over SoC power management, it > needs to be explicitly requested to reboot the SoC. Add support for > it. > > In some systems however, SoC needs to toggle a GPIO or send event to an > external entity (like a PMIC) for a system reboot to take place. To > facilitate that, we allow for a DT property to determine if the reboot > handler will be registered and further, the service is also made > available to other drivers (such as PMIC driver) to sequence the > additional operation and trigger the SoC reboot as the last step. > > Tested-by: Lokesh Vutla > Signed-off-by: Nishanth Menon > --- > .../devicetree/bindings/arm/keystone/ti,sci.txt | 1 + > drivers/firmware/ti_sci.c | 85 ++++++++++++++++++++++ > drivers/firmware/ti_sci.h | 12 +++ > include/linux/soc/ti/ti_sci_protocol.h | 11 +++ > 4 files changed, 109 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.txt b/Documentation/devicetree/bindings/arm/keystone/ti,sci.txt > index 965d45e313b1..ed5b8fc185f1 100644 > --- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.txt > +++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.txt > @@ -38,6 +38,7 @@ Optional Properties: > - reg-names: > debug_messages - Map the Debug message region > - reg: register space corresponding to the debug_messages > +- ti,system-reboot-controller: If system reboot can be triggered by SoC reboot Don't define bindings incrementally. But all the binding in one patch. Rob