From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757707AbcHWWpG (ORCPT ); Tue, 23 Aug 2016 18:45:06 -0400 Received: from mail-by2nam01on0045.outbound.protection.outlook.com ([104.47.34.45]:52969 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751392AbcHWWpA (ORCPT ); Tue, 23 Aug 2016 18:45:00 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jan.Glauber@cavium.com; Date: Tue, 23 Aug 2016 23:09:34 +0200 From: Jan Glauber To: Wolfram Sang CC: , , David Daney , Subject: Re: [PATCH v10 3/8] i2c: thunderx: Add i2c driver for ThunderX SOC Message-ID: <20160823210934.GA28936@hardcore> References: <1ead8831e4dd879d452e8bc1a2a33ccba3a74b3d.1465997604.git.jglauber@cavium.com> <20160823203628.GB20872@katana> <20160823203941.GC20872@katana> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160823203941.GC20872@katana> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [50.233.148.156] X-ClientProxiedBy: CY1PR12CA0058.namprd12.prod.outlook.com (10.163.230.26) To SN2PR07MB2592.namprd07.prod.outlook.com (10.167.15.22) X-MS-Office365-Filtering-Correlation-Id: ac54f31a-0dfa-4e39-48a8-08d3cb99ca95 X-Microsoft-Exchange-Diagnostics: 1;SN2PR07MB2592;2:hN/V+C/WD0qifgrAgCSavaQRHKXAPhnvcrI0N9v2W58L/P8B41BzVmR/6W9DRIbrak61VAJJeEoKQBn8LJpb8jHU4qmoOVLp2xRBxt7BctHH/TmWZxHDeEWUDNwpW9AkIhHAGjNZZNSqwYKARy78AACSZvRmr3b0QZn3e1dPtSnV9YCHxovZUnyGfxS3YrBH;3:lghyB1zsfHHEnMygpRwTAROcoUfRcgKdXt1n8oDwpwSx/NYoYPI+bdIL8C98tV1+AbV2GQIygutvo08NCjhwC7ShL4/9pPm5S9lUJ5dCbu9AXQy+X/X4ZUymMioPxLHr X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN2PR07MB2592; X-Microsoft-Exchange-Diagnostics: 1;SN2PR07MB2592;25:Ab9i9TwJR8cwijzAIAMuTPQTpb1/FmDp5hoswPNma4BWRofq4n776AdPi3sUJcEknGvp/O3UIhSnScgaIY2fGrBWWrnMlRCWmcr4kyweKu0yvWdgCwQCEsYwU1G02PSlzH2Ir02LLhgxEAbhGLQ1NQuJTQBB+aOnxXsIFxA58FVvJuKiZBf/kGY2u19bVxz1LPeNm79IWCfxoyAo2PH59bp3Vo4Sb5dY8N5Vd+xYNQoRV8jaPUxyT2Wu++koHfQPGaqIRIJ5S7lnEjrjHwsJk3kqrmJxcF6uJULTpTI3PUjo3bwf9UNdUU9RhZYIQYPEadgj376kyIt0fLpeP387S1Jl44rW6Grc7n3V+cxUl/IFEpo46gXQ3uRSUVilBCyBFdoHRPH2kE7uHQm8oYSmBnbPk154db1XqNuAhmsUr/HByU5PBYSBAGWbH2zBhSXXgQqqs16bC/LG6rzHcnpZat38cGXhcDepOrsUnsyeQC2gE/DvCDVwoCuS26WEWh4ixSZwzdl9jNHKydxLLWMTtF6Tj3MHxhP1a0gc1U+4Px9TS0Xw9qSQHuJ46Tq/LarOx3cMW9c9MwviAotEUFf8ciQ//KLQHvEnO2h/QBsihGHoEuchJurW7ljd6fDQfIuTSQJWeAnLhGbUo1D0NYXOwiOJ7RKtucJZbcyUYh4GF5E+HFtA4oOyMt2V+SjnU3/ltmb5ZgaA2/E3RG1kQlwdKA==;31:mmq7FpVGUiN08pXP0RhKofOyLj4CYh6wDClKVhP3T+2tBM4ZtPASVx375ZS4+BaXGH2jtIb2OCduENZj1mZtKC/1CahZSNahZO45qRTtVCJkH1oe44G3Vx/u4EnBcxwAMHauuMZqlvjrrWWm2Y1efsXZVm90+4ByuiM3xr2Lyky+yrmqT3vhdRzn1C8lkA+zjstYAEOzdlzkhKm1dFA/nW1AnKfNxJapqHWt/mkKeX0= X-Microsoft-Exchange-Diagnostics: 1;SN2PR07MB2592;20:s8hGFbJyjgcEqY4BTHmLC9xTF39SmOagZcn+UL6lY0cLw0bOiq7moM9EzrLBMndvHVJ2Mpjt+8ijFR4aRLav2QNBF7owFYkALP5wo+aJ6RyG1mgrG3LLKAinaarxfFiJ8UKymtw5iolCzk23lgvIhhC2fw75/xHYDL3vMMyEgOwEy30586n278TEILkjRx+1KhZbCEd0kAeYDjvDFzM8zcELTEf62/KBueEE2IxRLpwt4FKcn7BkpT2yJtF5piNYXSkNpWnwyDKvqzGhYwgNJd1biwHcIJDcDtvkQKtAHw5fR3QgdNZfIen59tMBegJi2Bs8N/aBiuAhYeGq3Jr5DvPomI/DF/TvpOmelS8bUIezq+6YN7n4eN/pHTTgqQ3JznQDMb6xE1k+caeu4DQ2IobIt0McgGP8jWqKcxc6H+fOKx7W0Cv8N3prEuKJoQ0mzgQcEitthrKZEBHcf5FSBNiZC3SYykedLUdGI6UQgmNzUDqoVoq8xKjVVaERtuDFYwuRIWibXoVyjXH3lqoJjTOFGTzkxRVhTDFJMZ/U0jtKMNnmjQFuPo1KJffkOHrrh/ab7yHy5xMinSKhiXHIqQBFgE6i1AJ/1d4fL9UmUBk= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:SN2PR07MB2592;BCL:0;PCL:0;RULEID:;SRVR:SN2PR07MB2592; X-Microsoft-Exchange-Diagnostics: 1;SN2PR07MB2592;4:SasPX081OlCr837mJXi8JY8FIY5XN13yH6kUEX8vbjUUyxgE/ij05orOtiHcrXJTViHrTzzu6tpre/Pa+PDCsJTJ+oO8gO8C7fKja2U2cssvJ7d1DNCxvmxKdHlcohMi2kG7xbHt0N5IXIhY0xxVXL4ZzQgaz+r1prxxD2KHJCC3oODj5XhTCAIdh/tt1WgjnCTjl+fQSef8gCOTxJXwMJOmvZA7s+exbSCsQGvYFS/Ems6vvf3qsKYi1ipQW4wWE8pWCF4NcWMZ2yv1RKwWtmzSLBllmcBaaCbhY89F3kvRsLfl6vZbEXCy8JSvVh4E9WVGwKry7nHV0+B+d7OsWEXIDTspDOl7ZdUrDJAKkxXOvlDrAFkT8O0N/xyq281P X-Forefront-PRVS: 004395A01C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(24454002)(189002)(199003)(33716001)(50466002)(68736007)(97756001)(189998001)(77096005)(97736004)(4001350100001)(107886002)(110136002)(46406003)(105586002)(5660300001)(54356999)(76176999)(93886004)(106356001)(42186005)(47776003)(33656002)(9686002)(50986999)(66066001)(101416001)(92566002)(586003)(1076002)(6116002)(7736002)(7846002)(81166006)(83506001)(8676002)(23726003)(81156014)(2950100001)(4326007)(305945005)(3846002)(2906002)(4001430100002)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN2PR07MB2592;H:hardcore;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SN2PR07MB2592;23:Yd/H6obTf2YX94YFf4fgmnvvZ52A/0k+H78Bzuo2j?= =?us-ascii?Q?O/dH4WuICj+VWBOzvsS37n8qvyVJ9gAeWl+U7+1UuG4STYN1GezxZ2jfnEFL?= =?us-ascii?Q?/+c04zvJShXAbO9lH8/qslnaUITNBmC7MdePC/1gUAu3wqeNFYUuUWJOqn9E?= =?us-ascii?Q?euOxRZlReMaPCCwRqnc7uoHJegExQ5g51KaiFRmQCzjaBqRuAJVRuMmOTovz?= =?us-ascii?Q?BPLhQ8UbLipMAOzEc/hzyc1K/BUr2Pl/P4IApjUlqlAjFbj/UJXQtq4E5wz3?= =?us-ascii?Q?3Vel5SCuhGgSC1U+B1DtTQ9E0G0ZDkMK//sT2WvhtcSPkueogj7t3d0/xybZ?= =?us-ascii?Q?NDtKJnqMeW5yCTay0ddvT4b3LyvP0pIC0+gN6L+NziSvIyvIV+lk3NEKhTto?= =?us-ascii?Q?QxPybtA4ovCkWzaRiztbPpPULZkUVTu1pxoE09RaJi20oksK1K1cTBKkvxVv?= =?us-ascii?Q?xZ3R2DfNd8RRy3kgA7hJpC+JMMx1JvCF//7jaZjvna0sTHR7jTTzASp1xWzq?= =?us-ascii?Q?e8t+vQed5POMPTh4NXehdNkPDtQTbptYo7ks2cXyFVt/N/efE3PBFC884ec7?= =?us-ascii?Q?MKGZHgL8w2QcrrzwMxyiT6mePZoCijKYEMLrsKmZwtehPyEuMu7SSklCskFa?= =?us-ascii?Q?UMVGtmmytbIIEAZAlD4OZGKC+AxoYqJ9dhuchQmviQZzW49EHmdb9CsarlRc?= =?us-ascii?Q?8pt0H4Fz20caCHFASqB/EWbptbJK+b3XasmUz23Mpicxou2JUaILZdIraba3?= =?us-ascii?Q?GZXwJhKwuwfGjWKihltBZJERwhF5pIhDtQAdm8P+unf8Zc7+TmRrHZo5ZPwI?= =?us-ascii?Q?9tm8Zceqii0/7wEJZD46KiLmc+FFIZDa33BcHvzMM61N/bw/vLG4ZmKJdOY9?= =?us-ascii?Q?D7Ikq0Hs23qJtDHZJWUHZSw5qFd6LjALiiEz1zOEjVYOow+vmUUTtbykvQla?= =?us-ascii?Q?BGo9T9qhS6pNVf80Y3uCpI0vajpiH4jQnjlxqgUMXuK1yxT64cl8rRQeql31?= =?us-ascii?Q?MS35J8tL39QvrOZ+hH0HHK+ln0MSgalPrqwBC/1BKZQJeIuDtDOEEQW10BM9?= =?us-ascii?Q?XvlKDRIFjjDzw1yUXZCD44mebVkxIOroB6Yd0w9ptTkk/TYNLP9Cmo47X52G?= =?us-ascii?Q?Me52obZgZGNPfO+rdwvhrBucqTyRxMR8bZPgENMrO+h5hWpIJRn4g2yFpbb2?= =?us-ascii?Q?9sFv0zvj/D8Dxlk4U69Zy0u3RdtxUUcE3tj?= X-Microsoft-Exchange-Diagnostics: 1;SN2PR07MB2592;6:nElPnu4M+xVcSuk1iPZyZH12HJU2gkgsCTCQFkbozr10nwfe1n2uBpkAjbNM7jxAwmDtRxe51Kk/QtZ4w2tOBTUijpDR2q/pYaQgU/uR07Ggb6Kr4+ttw8ln3GsMqTFPuMZTfq0WSz2y7WC5b4NO1GurX8yt54UM7RAgQon4l5sdGmp2rlKPNmEDkgFlqxMhs9gej0B4OYj2IPbm+vljOJrRbk5GaUSUpaGCeIVtNWdmdfHymYH3ujVVVRARCVUiZ4IFLXJcokFYpsZ1koyeYEd0ar6bxXice3b4KVbixeU=;5:yVufpTeyRO8VrLS9GJVUPM1mt53uiAdXv+q2fP8gV9nw+oqi4lIVFt1n53L86wU4OW6rKt86NBZh2fli5eco/3AeZXrQgztgzekQ7ZS9U9rUKw23Ul7lRGXZyTuxvgNR/N4dK4tsKhv2+rS8VkYc+Q==;24:sQmubVOQcTqxuVuFBiRQZ4clDtScfqw0PAhfzOR/xgeTeAn3Kkn5h4iJynsI9VoSre6pa0fAVZVNqQX6qJ2DWfV64MvQfZAMQqShWaK9y4E=;7:o1r8yUpE3vWYUzYNQaRQjbTQADmA7G2VFXB9GoR2XWUpmCvT/xgQN0J6cwLfHhbuCI1zu2acRWdY7bRLU+sOOc2j2JVEuMuY7PQxBJ+0W2jVsfvqq1ZI3SgbWp/+kortg1EMeiN8fvZxG82FmljfoeLcUMWctSrN5NXsJAhg5ePh204Txj4+oa4UMWVno1F8DnYPOGI1lGtMu1t738UTGdkP1uJJwdv9I8nxCho/B7XyEuT5OafsXHtGwkU+BxAH SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2016 21:09:37.4414 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR07MB2592 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 23, 2016 at 10:39:41PM +0200, Wolfram Sang wrote: > On Tue, Aug 23, 2016 at 10:36:29PM +0200, Wolfram Sang wrote: > > > > > i2c-octeon-objs := i2c-cavium.o i2c-octeon-core.o > > > obj-$(CONFIG_I2C_OCTEON) += i2c-octeon.o > > > +i2c-thunderx-objs := i2c-cavium.o i2c-thunderx-core.o > > > +obj-$(CONFIG_I2C_THUNDERX) += i2c-thunderx.o > > > > Shouldn't that rather be "i2c-cavium-core.o", > > Thinking of it again, it should probably even be "i2c-octeon-core.o" to > avoid confusion because all the functions start with octeon_* > > > "i2c-octeon-platdrv.o", and "i2c-thunderx-pcidrv.o" for the -objs? > > Those names still make sense :) > Agreed, the naming you propose looks much better. --Jan