From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756898AbcHWVPz (ORCPT <rfc822;w@1wt.eu>);
        Tue, 23 Aug 2016 17:15:55 -0400
Received: from mail-qt0-f195.google.com ([209.85.216.195]:36241 "EHLO
        mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751550AbcHWVPx (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 23 Aug 2016 17:15:53 -0400
Date: Wed, 24 Aug 2016 00:15:50 +0300
From: Leon Romanovsky <leonro@mellanox.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
        Eli Cohen <eli@mellanox.com>,
        Jack Morgenstein <jackm@dev.mellanox.co.il>,
        Or Gerlitz <ogerlitz@mellanox.com>, Matan Barak <matanb@mellanox.com>,
        Doug Ledford <dledford@redhat.com>, Sean Hefty <sean.hefty@intel.com>,
        Hal Rosenstock <hal.rosenstock@gmail.com>
Subject: Re: [PATCH] infiniband/mlx5: Remove superfluous include of
 io-mapping.h
Message-ID: <20160823211550.GQ15065@leon.nu>
References: <20160823201626.13926-1-chris@chris-wilson.co.uk>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="5KxTQ9fdN6Op3ksq"
Content-Disposition: inline
In-Reply-To: <20160823201626.13926-1-chris@chris-wilson.co.uk>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--5KxTQ9fdN6Op3ksq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Aug 23, 2016 at 09:16:26PM +0100, Chris Wilson wrote:
> This file does not use any structs or functions defined by io-mapping.h
> (nor does it directly use iomap, ioremap, iounamp or friends). Remove it
> to simplify verification of changes to io-mapping.h
>=20
> The include existed since its inception in
>=20
> commit e126ba97dba9edeb6fafa3665b5f8497fc9cdf8c
> Author: Eli Cohen <eli@mellanox.com>
> Date:   Sun Jul 7 17:25:49 2013 +0300
>=20
>     mlx5: Add driver for Mellanox Connect-IB adapters
>=20
> which looks like a copy across from the Mellanox ethernet driver.
>=20
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

I assume that it passed 0-day builds.

Except the commit message, which doesn't follow SubmittingPatches guide,
it looks good.

Reviewed-by: Leon Romanovsky <leonro@mellanox.com>

Thanks

--5KxTQ9fdN6Op3ksq
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJXvL0GAAoJEORje4g2clinc8IQAJZVu/u09AeK7VM9oOJAEzb1
ByrC1IElZ9ur9LYqQ5pdIIIshjCL2uNzm0xwsjDz65kt6+RoLdyk41OKiHjePb1F
H++PXhCAH5i/N0UzuXpcSRhb3kBpxShmpTgz5AWvz0TqT2P6s+PcAaSeBia18D7c
jO3PL62DAvy4xQbeEios8PV/wib5SM2jPIxQ4Ve/WNRIygUSKqYuqu0qFK+VXrJ3
3edlONcqowP3RvLN8P+m1eJKlGHZ1Jj2fNSQMZcfLzum73vmfr6XMPGiYs032mik
zPeQamR4OqI3NwPzJM85q5/Fn+0rQzeMkGzeOLr2vO5lVLq5m5sXEB/JIc/orMx9
vZTLxOMsEDKaV955o8QlP3kAz5db9DF6TPtuOlR+kCmqFhrAAfibD2pWj7nCklcC
gyYzXp1U6btUTXb+pjfTj4KpGnkYLwIQr0QbKHzHkrg7AH3ZWWtrfczBW8/TUd3h
fruWnpYBMLz6ivv/xpmZKoUzDKi4J9kDXgX4738Rq3O8+unL/xyhrPn1Hw/llVFO
35LiwXNxsEtleGXNOqxR13JKRRt3WDo8O2twMTxmCQtoJdl2tNvEVDyoCDDNUNtu
rFMhtpflHj0gnBf8VxV3dp/VZ2j6AloN3pOIaLFiuvzdqbYxVoZeLWVdvWmehF2R
b7WwN5qFBX90fLeqFE+2
=E2qG
-----END PGP SIGNATURE-----

--5KxTQ9fdN6Op3ksq--