[PATCH] infiniband/mlx5: Remove superfluous include of io-mapping.h

[PATCH] infiniband/mlx5: Remove superfluous include of io-mapping.h

[Chris Wilson]

This file does not use any structs or functions defined by io-mapping.h
(nor does it directly use iomap, ioremap, iounamp or friends). Remove it
to simplify verification of changes to io-mapping.h

The include existed since its inception in

commit e126ba97dba9edeb6fafa3665b5f8497fc9cdf8c
Author: Eli Cohen <eli@mellanox.com>
Date:   Sun Jul 7 17:25:49 2013 +0300

    mlx5: Add driver for Mellanox Connect-IB adapters

which looks like a copy across from the Mellanox ethernet driver.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Eli Cohen <eli@mellanox.com>
Cc: Jack Morgenstein <jackm@dev.mellanox.co.il>
Cc: Or Gerlitz <ogerlitz@mellanox.com>
Cc: Matan Barak <matanb@mellanox.com>
Cc: Leon Romanovsky <leonro@mellanox.com>
Cc: Doug Ledford <dledford@redhat.com>
Cc: Sean Hefty <sean.hefty@intel.com>
Cc: Hal Rosenstock <hal.rosenstock@gmail.com>
Cc: linux-rdma@vger.kernel.org
---
 drivers/infiniband/hw/mlx5/main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
index a84bb766fc62..1b4094baa2de 100644
--- a/drivers/infiniband/hw/mlx5/main.c
+++ b/drivers/infiniband/hw/mlx5/main.c
@@ -37,7 +37,6 @@
 #include <linux/pci.h>
 #include <linux/dma-mapping.h>
 #include <linux/slab.h>
-#include <linux/io-mapping.h>
 #if defined(CONFIG_X86)
 #include <asm/pat.h>
 #endif
-- 
2.9.3

Re: [PATCH] infiniband/mlx5: Remove superfluous include of io-mapping.h

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 848 bytes --]

On Tue, Aug 23, 2016 at 09:16:26PM +0100, Chris Wilson wrote:
> This file does not use any structs or functions defined by io-mapping.h
> (nor does it directly use iomap, ioremap, iounamp or friends). Remove it
> to simplify verification of changes to io-mapping.h
> 
> The include existed since its inception in
> 
> commit e126ba97dba9edeb6fafa3665b5f8497fc9cdf8c
> Author: Eli Cohen <eli@mellanox.com>
> Date:   Sun Jul 7 17:25:49 2013 +0300
> 
>     mlx5: Add driver for Mellanox Connect-IB adapters
> 
> which looks like a copy across from the Mellanox ethernet driver.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

I assume that it passed 0-day builds.

Except the commit message, which doesn't follow SubmittingPatches guide,
it looks good.

Reviewed-by: Leon Romanovsky <leonro@mellanox.com>

Thanks

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] infiniband/mlx5: Remove superfluous include of io-mapping.h

[Chris Wilson]

On Wed, Aug 24, 2016 at 12:15:50AM +0300, Leon Romanovsky wrote:
> On Tue, Aug 23, 2016 at 09:16:26PM +0100, Chris Wilson wrote:
> > This file does not use any structs or functions defined by io-mapping.h
> > (nor does it directly use iomap, ioremap, iounamp or friends). Remove it
> > to simplify verification of changes to io-mapping.h
> > 
> > The include existed since its inception in
> > 
> > commit e126ba97dba9edeb6fafa3665b5f8497fc9cdf8c
> > Author: Eli Cohen <eli@mellanox.com>
> > Date:   Sun Jul 7 17:25:49 2013 +0300
> > 
> >     mlx5: Add driver for Mellanox Connect-IB adapters
> > 
> > which looks like a copy across from the Mellanox ethernet driver.
> > 
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> 
> I assume that it passed 0-day builds.
> 
> Except the commit message, which doesn't follow SubmittingPatches guide,
> it looks good.

If you mean the full commit reference rather than the short form, the
long form can be preferred if it lends significance. In this case I
wanted to highlight that it was the original commit that introduced the
include.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

Re: [PATCH] infiniband/mlx5: Remove superfluous include of io-mapping.h

[Laurence Oberman]

----- Original Message -----
> From: "Chris Wilson" <chris@chris-wilson.co.uk>
> To: linux-rdma@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org, "Chris Wilson" <chris@chris-wilson.co.uk>, "Eli Cohen" <eli@mellanox.com>, "Jack
> Morgenstein" <jackm@dev.mellanox.co.il>, "Or Gerlitz" <ogerlitz@mellanox.com>, "Matan Barak" <matanb@mellanox.com>,
> "Leon Romanovsky" <leonro@mellanox.com>, "Doug Ledford" <dledford@redhat.com>, "Sean Hefty" <sean.hefty@intel.com>,
> "Hal Rosenstock" <hal.rosenstock@gmail.com>
> Sent: Tuesday, August 23, 2016 4:16:26 PM
> Subject: [PATCH] infiniband/mlx5: Remove superfluous include of io-mapping.h
> 
> This file does not use any structs or functions defined by io-mapping.h
> (nor does it directly use iomap, ioremap, iounamp or friends). Remove it
> to simplify verification of changes to io-mapping.h
> 
> The include existed since its inception in
> 
> commit e126ba97dba9edeb6fafa3665b5f8497fc9cdf8c
> Author: Eli Cohen <eli@mellanox.com>
> Date:   Sun Jul 7 17:25:49 2013 +0300
> 
>     mlx5: Add driver for Mellanox Connect-IB adapters
> 
> which looks like a copy across from the Mellanox ethernet driver.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Eli Cohen <eli@mellanox.com>
> Cc: Jack Morgenstein <jackm@dev.mellanox.co.il>
> Cc: Or Gerlitz <ogerlitz@mellanox.com>
> Cc: Matan Barak <matanb@mellanox.com>
> Cc: Leon Romanovsky <leonro@mellanox.com>
> Cc: Doug Ledford <dledford@redhat.com>
> Cc: Sean Hefty <sean.hefty@intel.com>
> Cc: Hal Rosenstock <hal.rosenstock@gmail.com>
> Cc: linux-rdma@vger.kernel.org
> ---
>  drivers/infiniband/hw/mlx5/main.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/mlx5/main.c
> b/drivers/infiniband/hw/mlx5/main.c
> index a84bb766fc62..1b4094baa2de 100644
> --- a/drivers/infiniband/hw/mlx5/main.c
> +++ b/drivers/infiniband/hw/mlx5/main.c
> @@ -37,7 +37,6 @@
>  #include <linux/pci.h>
>  #include <linux/dma-mapping.h>
>  #include <linux/slab.h>
> -#include <linux/io-mapping.h>
>  #if defined(CONFIG_X86)
>  #include <asm/pat.h>
>  #endif
> --
> 2.9.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
I compiled and tested this with no issues on my mlx5 test bed.

Reviewed-by Laurence Oberman <loberman@redhat.com>
Tested-by Laurence Oberman <loberman@redhat.com>