From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932992AbcHWVw5 (ORCPT ); Tue, 23 Aug 2016 17:52:57 -0400 Received: from mail-bl2nam02on0065.outbound.protection.outlook.com ([104.47.38.65]:52047 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932939AbcHWVwx (ORCPT ); Tue, 23 Aug 2016 17:52:53 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jan.Glauber@cavium.com; Date: Tue, 23 Aug 2016 23:52:47 +0200 From: Jan Glauber To: Wolfram Sang CC: , , David Daney , Subject: Re: [PATCH v10 4/8] i2c: thunderx: Add SMBUS alert support Message-ID: <20160823215247.GD28936@hardcore> References: <4ba9512e145ee8d303393874a0033ed83ae33a8f.1465997604.git.jglauber@cavium.com> <20160823205724.GD20872@katana> <20160823212859.GC28936@hardcore> <20160823213948.GH20872@katana> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160823213948.GH20872@katana> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [50.233.148.156] X-ClientProxiedBy: BY2PR04CA044.namprd04.prod.outlook.com (10.141.249.162) To SN2PR07MB2589.namprd07.prod.outlook.com (10.167.15.19) X-MS-Office365-Filtering-Correlation-Id: f35bb75e-4b93-44ec-c6ba-08d3cb9fd3ff X-Microsoft-Exchange-Diagnostics: 1;SN2PR07MB2589;2:hRiFcfyYNtGyKjowZGVaHyXQUziWhRP32uFkfCBNqIsKUIY5c3iunS13HLlH2MkutF3I0zWzzHR8zVvEaJsBvJR+PS7Dkh6CbL7QJYLaoWyjLgL1lmHVdGM4UcPiErihnFjwZ1KJQ2ld1aaP7/YvY36ODvhvK36YEJICPQKf+oPZq/yCq+Lw6h0kvatAKsD9;3:G8D7PWH3T6jQBoG6o/4LHS7BssZ5Oh6/uuqmD8ds3cuL8SdulvCmHHZVHfmqM1JvAECAojNV/eiH6B/G5eFT2EZDK3WK8SQjBToPok7PrWazHUDSih/6SdwHjW65vdtp X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN2PR07MB2589; X-Microsoft-Exchange-Diagnostics: 1;SN2PR07MB2589;25:F9p+YGak6KfnI8glhMgxJj9ydHsg72qPwaa672F36y9kXg4wWjTkOqxIYO+bIBtgxJ/2Wzvkrbsyvz7xGfUzR2i0VMy4TjRl8VLy38D03UtXn5NSY5eYGRkbPZD2A+84iJ7XvH4mpf1sB7NjKkKKaGDCyuCVDfY3cio32codJUPP8Nr1R3Cpl+7Lbaf5VAJMt/TQAgh9uzjiTGiPKEshPZDhGtAunUVaHY211vP0T/5R3HZ2aaw2z1HXn2zAF5ASNkvAsmy4agXLBek9X3Z9c/YUynVlktIftAVSeshEX6009dA4W9GheVSx/zVYQuSQZeYsZZPOrbDSCmhkJIR+iRC83jQ2kNwGf82TTe24kMbAJQHO5ANm6POiSkZcqoWW9JAyJyjycVZ84MK92NR5jzk6XXUF7Js0kEBLTklyrd2GSyBoOJSWVDYEYpyKX3eOZUwHSclkuGBnd2wjyk/mj3ME3E5wLI4FciXhtAMvAoW+qy26kMfRlZcSgoFeXItfn4hUFCYyRx+jb6XAmOinyFyf9ENpHGRqHI+4B87DW0wq6JZauT/17m0bSqWvWGwqj9PVPQRsUvB+idMy15MuEWDcKhl6Jy0c4lLRIvIY9tnis+B/SMK42AlawF90+pi5LKr7bb+Tme2Nv70JmVe1U2ER7dPxy3whbP/s7Nm5OzQoG8kXgBDj8HdPYsdtpKWbXE5n3D88G1XH7lrx7G0DiQFa7WgsQMvYESbn1j8tumsGbXuPTmtNplQxFieZSpMb X-Microsoft-Exchange-Diagnostics: 1;SN2PR07MB2589;31:irJu27obzwxbs5ZiJBWqbsEfiG2xLEYWeoPuvB5vthROgs0kEVQZJCGWPkRHdMT7SXwpUPOgY+v+yaVPfQxF++00BvKkqzg56csTsx6nT2hG4QPt58B7gbn1GQ88RCaQgIGJAgXQ/aCBUQuXbauUUpXjlT1AO8BOOMYd4LhB47Q2QNvA0ldxXj1DVgwpWeSniXkRBxFyhsK/gr6pZQi8kn2U702TrMExH+eMYZ0/JCY=;20:Ag1UY9wDqhwXAwKzMBAz/86NUlraBljUaDviw06Z6GeHfrIftfHRl+ElX/7wR5M3AdWRVY/fK0PHb5LDxfbla6boHwL8rYMjkkSB1Rr7lFmeoqLaMYALRSo1yeSpU1sz6Zdk8QYZ596LKWiRDlDdofv2uSsni4VvLpEgARqk+VGaYaO/CltbJGCssKkS/oPHLEueHG24smR9sNXU8xKzZafEt6VnZyhnATFUBnv7EEW5xvaBVomWu6noBu/F2w352oLGJ+Q/A9L8MLsJtXmmQk3N0I0db6kIhCZCHwqPosv6EgGwdt4gsmS3yQNnD/2m8zyMLatsqcg79df+mpRvmQvSV3HsStDwjAESNNQTlfDcvG86GjrlpCQA7tWQyjOa7ljoPnVuRT9u/fx8Cszgfq1amX4OZDxmv0EsfwZNPK/UYRq7H9tlCY9Z+cvEK8E9lOgcWy1Mwu/dCtyZMnnqvPDvED/D0DzVA8PPcGwcFIw27QV49o2WhKpVydkPhOtlfWsKIc785V0tpQy43dHIJcwTrJSkPy0iDPIEN7xC8f81t9qePEiKUl6z8QVk4rfF5PRHw7MRsPveuRZdKblq668GSI7mn2bPFTeC1pLD9lc= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:SN2PR07MB2589;BCL:0;PCL:0;RULEID:;SRVR:SN2PR07MB2589; X-Microsoft-Exchange-Diagnostics: 1;SN2PR07MB2589;4:ZoCSffVOovR5c0IAQM0MutoJmcPc6sLb6EnWn0KFUKGXLS/jIQTpGomV4wSepHL8MnWEEdgiJugOit5vA/3/xXKSM8Bxz3idV901rQxqFP+BTfjHzL5su6M9cx7SiXoMccMquhLyLdUlOksYltpBGKnktFjWVhGWWAeoLeEqjVkXVpzt5wzeqb9WYDhA4K530yrMop+bjgni0LoA9K05UEGx7GOtVQOz+Eiuo8hR2Tz+F6o0EBDvyQx7sdqJopy1Zx0B8k3YNYPO96hdJSJ1p3jxlU1yoNs1NfzzrUxguCDdf3os3ggVUGbftVZ7t0a54F+3qdJK3f2ak0WLgg2wLoW0852y2nCwNNnmIFrWCkGDYp7TBGPAbW6pY2CvFQNm0Ju0163deIVFfkq8FrHaOw== X-Forefront-PRVS: 004395A01C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(24454002)(189002)(199003)(66066001)(81166006)(7736002)(42186005)(8676002)(105586002)(101416001)(189998001)(68736007)(23726003)(93886004)(106356001)(50986999)(110136002)(81156014)(33656002)(305945005)(50466002)(107886002)(7846002)(3846002)(586003)(5660300001)(6116002)(46406003)(15650500001)(33716001)(2906002)(4001430100002)(97756001)(19580405001)(4001350100001)(1076002)(97736004)(76176999)(54356999)(77096005)(9686002)(2950100001)(83506001)(92566002)(47776003)(4326007)(19580395003)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN2PR07MB2589;H:hardcore;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SN2PR07MB2589;23:Gc6fsioaVnJEJxoHyNfLtpNTFJ88kx1e7EurOiHrJ?= =?us-ascii?Q?x3UEzqlqgL/5Rox1NWQDQCwPqJt37ldCdiRBKdyYX6e3sm/bbiJsAtWpk1W7?= =?us-ascii?Q?fFTxTUAaUeZoREU3hUqqgO5UdHzmM7me/u3DyD/MNjhKaSh4uYVcAa/+2gBs?= =?us-ascii?Q?AEDeUf7YK4gpwXD4aqB3D1CxbJCYeJwDb7EOvrUCHZgJO2TjjipIM7i3I4eJ?= =?us-ascii?Q?5Y9uvo74puM6cQwywCav4qCo8YRE0zWBzrvChACdVG6mWE1NbuMZS5q/enFJ?= =?us-ascii?Q?MimoQVq+z4XnCym7jQPVYiPY34lJOS8d6P3oW5CPHSlR/AmkPGS5RWkL8uLM?= =?us-ascii?Q?hEMu3RHJdc0uNB7QECMVCR4IucXZ/mch/bwNvTIY4Cy31zuEd2YZht8HVfD2?= =?us-ascii?Q?rA0cgZxTC8joB56BD9CFzc1CbDc2oL1fz+sQ/PfoVoTHh38lffCBlGSIk5e3?= =?us-ascii?Q?bLZlCBLKNJRfbdIMKMIyyJDld+JWXRqo6F8gKsHM5WXrEs3AckhNpCDu2o3N?= =?us-ascii?Q?WiH+oPKP7Z3OYNYpNeXc+2A7DMoy5xQWcaXzbIDsi0p0fRB628LzIguVFoCU?= =?us-ascii?Q?kSPCHErOUIHfMNuS9gjXWwYJzvoNCU3sw3W9wzSx2Fd9nDoF8hqndEdBWcaI?= =?us-ascii?Q?sB8dzL9+DK0p+ezeFXtW21vBmvfjHmqK7qNsYot0XnA1U53vt3sGAXfWe7mw?= =?us-ascii?Q?wi2+vi8P40AA7zXNNhbY8nREXEYBrQ8R/JifsHshWcpRWOnEpXul/Kqnen7K?= =?us-ascii?Q?aTlyaAj0S0MBeYp9cJs19cXACyVqSIFi91EBi4cjUDNQMeANI7uU+vmEvoBQ?= =?us-ascii?Q?zwhv4QtO6llJ7nyfrOolQSr7VMdSc+GAdwwojXjWlKjN1tJminpr3qEbnIYU?= =?us-ascii?Q?HYqCUZOUCWuyVFhA8uDwIr1cOXZ6I1AakTvcMAmGbs3oRpEnaZOZHr3ZBIzQ?= =?us-ascii?Q?7J5FQKLMCziUV+kyR37+Kq2rvJPYcXzi+CG7tOg9II1/cTzdA+TGymvcA/JB?= =?us-ascii?Q?AU1Bk1Af/phwP5B/XE1JRqQcYvukLYnSIJdiy2i++zbBX+Sw80xv0SfM4nY+?= =?us-ascii?Q?nHvwi/AzmrOz4VYtT5NfKei1lQ9NrXSYvCXIHCCmjvqMS1iDNEFHeIO6v1z4?= =?us-ascii?Q?P56riiI8JATxMhOE0z6w0O8Bnt9I8HtskbzFRB39Q/MFxK/eeTcj2eSAtKkP?= =?us-ascii?Q?ipafh/eV96CisJrhUUWvO2i7MzABHGXCvIwTj4keD2974Kf4DmCpik/YafCZ?= =?us-ascii?Q?2wvHzFuyaLWVcybvceexSOjuGRk32mfZGzEoGSW5T/h3rXIlB23HAAFlfShL?= =?us-ascii?B?Zz09?= X-Microsoft-Exchange-Diagnostics: 1;SN2PR07MB2589;6:1prH0OhT5rXpCcrRXsD7rBr4QWZ2A1PS6WT3fmhi4aTg/OWklCPChdQGNV9EP7Fk+188b0xTQ6ei9ER+cSTtJIa9PrPZu4DzOrC1ScpF2SxG/5mmO+6A0gBblFjYl+At4ZKvUhu7KjiwQBPafmGpf3RivJmrqbPBPBQvJ8HH9tuRXdA/MnBoOgMfcy5ouqjnh+AEyM1QF/xy17VmlfmN4uVbRlin4qvyT2xgJxvCLE3sNGE3LScWIrKwToCNs6HMZtyCDEwgUW/+/Ui/FRlPknCkYfa9RodA19Xw8jP30n0=;5:1HW6mJS0ozyMLTzA/Mr+VMw62uARKNIAIh2uKiJ+0V9sV1LyccwHfktjJXfRyRJhBsTwYFawhtHfN8HGL9dKAG82o5k78cRtq1B8tO/3P1y/ogYUbmKtHOvYI5GgikiNiyoF/Lot+3dt133WwaOe8g==;24:7DqnKwwwbh+mDrZGwMvNlghVHxAW3wL4uDl/iewTfU8oL1PrlgnSB3z06xYd4b838E9Cc1jBH+TIiTKG3DCcx2/x2IafbDcxeJJZ44X6LdI=;7:gkmSFRIQB+bcLeU51PnwcEkxNQNvyjDuMlkWz1wGk+xmK3ZeZU1/ylFY5QfeT4eT5ghT5NXGmT7s1wtJLPTfzAnosZnIvWyBSIbIt0pTzX16exkhfYXdIPwetGfHIMw7edYl3oM5ofplvBc9G9jRg3Ii7LkQ6pRVWK7el4T10zoj/l4rGEyUTUoGUWHtL3IewZ4qnLTZ9lmiHZq+wMVKsiaDH1PkiU6MjBcbiR0gGeMC5YSSzReTzRmhorFMz3yu SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2016 21:52:50.3753 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR07MB2589 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 23, 2016 at 11:39:48PM +0200, Wolfram Sang wrote: > On Tue, Aug 23, 2016 at 11:28:59PM +0200, Jan Glauber wrote: > > On Tue, Aug 23, 2016 at 10:57:25PM +0200, Wolfram Sang wrote: > > > On Wed, Jun 15, 2016 at 03:51:30PM +0200, Jan Glauber wrote: > > > > Add SMBUS alert interrupt support. For now only device tree is > > > > supported for specifying the alert. In case of ACPI an error > > > > is returned. > > > > > > > > Signed-off-by: Jan Glauber > > > > > > What about 'select I2C_SMBUS' in Kconfig and skip all the ifdeffery? > > > > > > > Wouldn't that prevent a distribution that has I2C_HELPER_AUTO set > > from enabling the ThunderX i2c driver at all? > > From commit e2ca307439fb9df922c3e8891289a2ac05812fb7: > > ... > Bus drivers which implement SMBus alert should select this option, so > in most cases this option is hidden and the user doesn't have to care > about it. > OK, makes sense. I'll remove the ifdef's.