From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758009AbcHWWkr (ORCPT ); Tue, 23 Aug 2016 18:40:47 -0400 Received: from mga09.intel.com ([134.134.136.24]:50319 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752642AbcHWWkp (ORCPT ); Tue, 23 Aug 2016 18:40:45 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,567,1464678000"; d="scan'208";a="1019279379" Date: Tue, 23 Aug 2016 16:39:57 -0600 From: Vishal Verma To: Dan Williams Cc: linux-nvdimm@ml01.01.org, "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Toshi Kani , linux-acpi@vger.kernel.org Subject: Re: [PATCH 0/3] acpi, nfit: nvdimm notification support + tests Message-ID: <20160823223957.GC7799@omniknight.lm.intel.com> References: <147198925154.3136.14739108342311837939.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <147198925154.3136.14739108342311837939.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/23, Dan Williams wrote: > ACPI 6.1 added an "NFIT Health Event Notification" for nvdimm devices. > When this fires, system software is expected to issue a DSM to retrieve > the latest health values. For the NFIT driver this notification > arrives as an event on the sysfs 'flags' attribute for an nfit/nvdimm > device. The 'flags' attribute reflects the "NVDIMM State Flags" of the > "5.2.25.3 NVDIMM Region Mapping Structure", and when read indicates if > the platform supports sending health events. > > --- > > Dan Williams (3): > tools/testing/nvdimm: unit test for acpi_nfit_notify() > acpi, nfit: add dimm device notification support > tools/testing/nvdimm: unit test for acpi_nvdimm_notify() > > > drivers/acpi/nfit/core.c | 112 ++++++++++++++++++++++++++++++++----- > drivers/acpi/nfit/nfit.h | 7 ++ > drivers/nvdimm/dimm_devs.c | 6 ++ > include/linux/libnvdimm.h | 1 > tools/testing/nvdimm/Kbuild | 1 > tools/testing/nvdimm/test/iomap.c | 17 ++++++ > tools/testing/nvdimm/test/nfit.c | 64 +++++++++++++++++++-- > 7 files changed, 188 insertions(+), 20 deletions(-) Looks good to me. For the series, Reviewed-by: Vishal Verma