From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755155AbcHXNUF (ORCPT ); Wed, 24 Aug 2016 09:20:05 -0400 Received: from helcar.hengli.com.au ([209.40.204.226]:40079 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754144AbcHXNT7 (ORCPT ); Wed, 24 Aug 2016 09:19:59 -0400 Date: Wed, 24 Aug 2016 21:19:01 +0800 From: Herbert Xu To: Sudip Mukherjee Cc: "David S. Miller" , Heiko Stuebner , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH] crypto: rockchip - use devm_add_action_or_reset() Message-ID: <20160824131901.GD4039@gondor.apana.org.au> References: <1471964334-27060-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1471964334-27060-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 23, 2016 at 08:28:54PM +0530, Sudip Mukherjee wrote: > If devm_add_action() fails we are explicitly calling the cleanup to free > the resources allocated. Lets use the helper devm_add_action_or_reset() > and return directly in case of error, as we know that the cleanup function > has been already called by the helper if there was any error. > > Signed-off-by: Sudip Mukherjee Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt