From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756577AbcHXNwA (ORCPT ); Wed, 24 Aug 2016 09:52:00 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:32797 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756537AbcHXNv5 (ORCPT ); Wed, 24 Aug 2016 09:51:57 -0400 Date: Wed, 24 Aug 2016 15:51:22 +0200 From: LABBE Corentin To: Herbert Xu Cc: mpm@selenic.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5] hwrng: amd: Be consitent with the driver name Message-ID: <20160824135122.GC29212@Red> References: <1471614177-12380-1-git-send-email-clabbe.montjoie@gmail.com> <1471614177-12380-3-git-send-email-clabbe.montjoie@gmail.com> <20160824105811.GA2120@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160824105811.GA2120@gondor.apana.org.au> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 24, 2016 at 06:58:11PM +0800, Herbert Xu wrote: > On Fri, Aug 19, 2016 at 03:42:55PM +0200, LABBE Corentin wrote: > > The driver name is displayed each time differently. > > This patch make use of the same name everywhere. > > > > Signed-off-by: LABBE Corentin > > --- > > drivers/char/hw_random/amd-rng.c | 13 ++++++------- > > 1 file changed, 6 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/char/hw_random/amd-rng.c b/drivers/char/hw_random/amd-rng.c > > index d0042f5..d0a806a 100644 > > --- a/drivers/char/hw_random/amd-rng.c > > +++ b/drivers/char/hw_random/amd-rng.c > > @@ -31,7 +31,7 @@ > > #include > > #include > > > > -#define PFX KBUILD_MODNAME ": " > > +#define DRV_NAME "AMD768-HWRNG" > > > > /* > > * Data for PCI driver interface > > @@ -98,7 +98,7 @@ static void amd_rng_cleanup(struct hwrng *rng) > > } > > > > static struct hwrng amd_rng = { > > - .name = "amd", > > + .name = DRV_NAME, > > Hmm, this changes a sysfs-exported name which has the potential > to break user-space. So I think you'd need to a stronger argument > to do it other than just cleaning it up. > amd is really really too generic. But if you still NACK that (and I understand perfectly why), I will update my series. Regards