From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755214AbcHXPjq (ORCPT ); Wed, 24 Aug 2016 11:39:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34548 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753083AbcHXPjo (ORCPT ); Wed, 24 Aug 2016 11:39:44 -0400 Date: Wed, 24 Aug 2016 17:32:00 +0200 From: Oleg Nesterov To: Michal Hocko Cc: Andrew Morton , linux-mm@kvack.org, LKML , Roland McGrath , Andreas Schwab , William Preston Subject: Re: [PATCH v2] kernel/fork: fix CLONE_CHILD_CLEARTID regression in nscd Message-ID: <20160824153159.GA25033@redhat.com> References: <1471968749-26173-1-git-send-email-mhocko@kernel.org> <20160823163233.GA7123@redhat.com> <20160824081023.GE31179@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160824081023.GE31179@dhcp22.suse.cz> User-Agent: Mutt/1.5.18 (2008-05-17) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 24 Aug 2016 15:32:26 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/24, Michal Hocko wrote: > > Sounds better? > diff --git a/kernel/fork.c b/kernel/fork.c > index b89f0eb99f0a..ddde5849df81 100644 > --- a/kernel/fork.c > +++ b/kernel/fork.c > @@ -914,7 +914,8 @@ void mm_release(struct task_struct *tsk, struct mm_struct *mm) > > /* > * Signal userspace if we're not exiting with a core dump > - * or a killed vfork parent which shouldn't touch this mm. > + * because we want to leave the value intact for debugging > + * purposes. > */ > if (tsk->clear_child_tid) { > if (!(tsk->signal->flags & SIGNAL_GROUP_COREDUMP) && Yes, thanks Michal! Acked-by: Oleg Nesterov