From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932567AbcHXOsQ (ORCPT ); Wed, 24 Aug 2016 10:48:16 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:58309 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754572AbcHXOsN (ORCPT ); Wed, 24 Aug 2016 10:48:13 -0400 Date: Wed, 24 Aug 2016 16:40:58 +0200 From: Alban Bedel To: Oliver Neukum Cc: Alban Bedel , linux-usb@vger.kernel.org, Freddy Xin , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] usbnet: ax88179_178a: Add support for writing the EEPROM Message-ID: <20160824164058.6ec64a8e@avionic-0020> In-Reply-To: <1472049039.11480.10.camel@suse.com> References: <20160824135231.21782-1-alban.bedel@avionic-design.de> <1472049039.11480.10.camel@suse.com> Organization: Avionic Design X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/plNYGCFSdTutFignJ/sblyd"; protocol="application/pgp-signature" X-Provags-ID: V03:K0:2ac/WqgUtSDS+SaEmKX1L/pbkKUjOicPebkDYpn6yPqih7x3TiX s4UdLvCIbMfOfdbFHz4HsfStMigrkfe+erw8RSNPBoNQsCfXpmhiM7Me9bLvydv96srakMY Dobm11ErNhxkx3QidWsFNw/yQ0BB7jqTAM8NJy2ECAIa76PeOeHdpgO4PQ7+ju3dOZUQ1xt F1vIhZBg+8Cg8hZiGt+Yw== X-UI-Out-Filterresults: notjunk:1;V01:K0:LiBt/CmPWbg=:HUYSBaZW/DXWS4KK/jT+y5 j2CCkBo9SxyN7JxCpf3aB0hEopZtzTIze6LUe70sEHmQ6ir7kdp31YOe2ax6Iyt63h5TBgoQ+ fuYJVzqq9ieSEv+ijKQJdGATiOG/meEvyKwRDnkSXw0TvGHy5pb/rXW00fk7Q3r4j68Yb8mPX 646RVJdutUKiRUoag/I+NzCKzQoyeMtcy6+oWfPXnwj5Rn06bu5YJdJ1lOFp25anaaIrznWH7 rPP4wZ7qQ/ePtxuKga1qqLUANw3+nqMv2MYGU4KzNn2kTw+vRgJ9cpTmWhDEXmbzKmA3H0yyi SJhlKfY7esVLlCACveffP/bmWLOQ02xuyOmEFjDKmJSh341c1snUDsgpV2rfy1y/STaSp04AU j9HcqZRMHN9bWC2Qe67qlthbshpqQnq86jBIMznnAW5HFAv+mA/bN5fPpvAi+eL7Au4iFK7EI +pVcQMfITf+3CAlutPV9CqGIx8OYQ8k0M5Xy8UyjojB31rJ0r3FRRuPin5xWpfdqdBBqI7T7f eL0YkRxbjpA59zHLTPj6yRfm/SsWLfM+Ou/ejipI/S3xbAV7U4uRtkWNr2IOFtiXeW7zQn2da Q6C8FF6SzAoEI0nqvbQ4g5GtIm8zlTj7bTR7BGrpTblynyq/nlPmq6UeT+EveBSc0bTg6X2QH gBEqwP5UQtS11x0XZEd/LhqCZmEWf5TKBsmNDV8DUZf+q0hxvQaROYAzvH+E6z6EoHgI= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Sig_/plNYGCFSdTutFignJ/sblyd Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 24 Aug 2016 16:30:39 +0200 Oliver Neukum wrote: > On Wed, 2016-08-24 at 15:52 +0200, Alban Bedel wrote: > > Implement the .set_eeprom callback to allow setting the MAC address > > as well as a few other parameters. Note that the EEPROM must have a > > correct PID/VID checksum set otherwise the SROM is used and reads > > return the SROM content. > >=20 > > Signed-off-by: Alban Bedel > > --- > > drivers/net/usb/ax88179_178a.c | 57 > > ++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 57 insertions(+) > >=20 > > diff --git a/drivers/net/usb/ax88179_178a.c > > b/drivers/net/usb/ax88179_178a.c > > index e6338c16081a..e6a986303dad 100644 > > --- a/drivers/net/usb/ax88179_178a.c > > +++ b/drivers/net/usb/ax88179_178a.c > > @@ -28,6 +28,7 @@ > > =20 > > #define AX88179_PHY_ID 0x03 > > #define AX_EEPROM_LEN 0x100 > > +#define AX_EEPROM_BLOCK 0x40u > > #define AX88179_EEPROM_MAGIC 0x17900b95 > > #define AX_MCAST_FLTSIZE 8 > > #define AX_MAX_MCAST 64 > > @@ -43,6 +44,7 @@ > > #define AX_ACCESS_PHY 0x02 > > #define AX_ACCESS_EEPROM 0x04 > > #define AX_ACCESS_EFUS 0x05 > > +#define AX_RELOAD_EEPROM 0x06 > > #define AX_PAUSE_WATERLVL_HIGH 0x54 > > #define AX_PAUSE_WATERLVL_LOW 0x55 > > =20 > > @@ -620,6 +622,60 @@ ax88179_get_eeprom(struct net_device *net, struct > > ethtool_eeprom *eeprom, > > return 0; > > } > > =20 > > +static int > > +ax88179_set_eeprom(struct net_device *net, struct ethtool_eeprom > > *eeprom, > > + u8 *data) > > +{ > > + struct usbnet *dev =3D netdev_priv(net); > > + unsigned int offset =3D eeprom->offset; > > + unsigned int len =3D eeprom->len; > > + int i, err =3D 0; > > + u8 *block; > > + > > + /* The EEPROM data must be aligned on blocks of 64 bytes */ > > + if ((offset % AX_EEPROM_BLOCK) || (len % AX_EEPROM_BLOCK)) { > > + offset =3D eeprom->offset / AX_EEPROM_BLOCK * > > AX_EEPROM_BLOCK; > > + len =3D eeprom->len + eeprom->offset - offset; > > + len =3D DIV_ROUND_UP(len, AX_EEPROM_BLOCK) * > > AX_EEPROM_BLOCK; > > + > > + block =3D kmalloc(len, GFP_KERNEL); > > + if (!block) > > + return -ENOMEM; > > + > > + /* Copy the current data, we could skip some but KISS > > */ > > + for (i =3D 0; i < len; i +=3D AX_EEPROM_BLOCK) { > > + err =3D __ax88179_read_cmd(dev, > > AX_ACCESS_EEPROM, > > + (offset + i) >> 1, > > + AX_EEPROM_BLOCK >> 1, > > + AX_EEPROM_BLOCK, > > + &block[i], 0); > > + if (err < 0) { > > + kfree(block); > > + return err; > > + } > > + } > > + memcpy(block + eeprom->offset - offset, data, > > eeprom->len); > > + } else { > > + block =3D data; > > + } > > + > > + for (i =3D 0; err >=3D 0 && i < len; i +=3D AX_EEPROM_BLOCK) { > > + err =3D ax88179_write_cmd(dev, AX_ACCESS_EEPROM, > > + (offset + i) >> 1, > > + AX_EEPROM_BLOCK >> 1, > > + AX_EEPROM_BLOCK, &block[i]); > > + } > > + > > + if (block !=3D data) > > + kfree(block); =20 >=20 > And if block =3D=3D dta, what frees the memory? In this case this function didn't allocate any memory, so there is nothing to free. Alban=20 --Sig_/plNYGCFSdTutFignJ/sblyd Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXvbH6AAoJEHSUmkuduC28PxMP/jlldiklI0roFS9o+XQD093B wyNzjIyAbnAjjOz1K/ptvi35JDl2omdhNC1Dpz2C7WQlcMHvHgZMLrvT2uwtTO91 fCXQ8h5eNxNmmLz8/4d3CiZsmrFBPiUo2EjNpLm8Uhw0JOp/Ofk67DOHZ8ffcXCR N9zo3lY7QczIh2KRGSuh4J0uTIwEfuo/+ri1r28J41hz5BiG+Zjw/w1Ja+pjgOLi SxrI2iszaeJG6p8RVdPlZ5gXmvsF3hFjg0pK4WR18EhLaahblJVqI6AZb5x05AU0 D+RKpiUWGWpwSTMCdL8v+zea2nHjqUImyk7nP+Ag1RtL2ay+gTSPikd0TAyiljGu Hb+bkb2Q2bGGGwXFewkpV7DD9RU0wDvrS6EQpmDKm85qekRFje/An9WYFirqbatc jEtTplRE3L3F0ywQOGQn77F+bGPZHO4e2tuZmPon0bto9bbDC1JDH1mXDpridGYx 1ksyP6oSWJ0dz6HVP8wBCXCRUu0ExUT8m/86LLlb1kS1x4G9HRC4uROywTRgIMzu 7ZHzKH+MKOREp9SRNi8xY7i1YECpdMpRgAhKQzgY8DairRH63l47Ju0wokXHFltc X4ZTrkCYhg8XK3XXqV1xbSZCTxfLsQe0jy+3dirlb7KB9mRxhAERBMNvPky5yFFC YwN/WUWdoWzl7iQpIq2H =gE2o -----END PGP SIGNATURE----- --Sig_/plNYGCFSdTutFignJ/sblyd--