From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759034AbcHYIPR (ORCPT ); Thu, 25 Aug 2016 04:15:17 -0400 Received: from down.free-electrons.com ([37.187.137.238]:32817 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755685AbcHYIOr (ORCPT ); Thu, 25 Aug 2016 04:14:47 -0400 Date: Thu, 25 Aug 2016 10:03:34 +0200 From: Maxime Ripard To: Icenowy Zheng Cc: Chen-Yu Tsai , Russell King , Hans de Goede , Rob Herring , Mark Rutland , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/2] ARM: dts: sun8i: enable UART1 for iNet D978 Rev2 board Message-ID: <20160825080334.GD7776@lukather> References: <20160823064451.25997-1-icenowy@aosc.xyz> <20160823064451.25997-3-icenowy@aosc.xyz> <20160824193600.GS8103@lukather> <43951472083107@web23m.yandex.ru> <97321472108244@web8m.yandex.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="xB0nW4MQa6jZONgY" Content-Disposition: inline In-Reply-To: <97321472108244@web8m.yandex.ru> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --xB0nW4MQa6jZONgY Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Aug 25, 2016 at 02:57:24PM +0800, Icenowy Zheng wrote: > >>>> =A0=A0diff --git a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts b/= arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts > >>>> =A0=A0index 78823d8..3ac22d4 100644 > >>>> =A0=A0--- a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts > >>>> =A0=A0+++ b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts > >>>> =A0=A0@@ -48,6 +48,10 @@ > >>>> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0model =3D "INet-D978 Rev 02"; > >>>> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0compatible =3D "primux,inet-d978-re= v2", "allwinner,sun8i-a33"; > >>>> > >>>> =A0=A0+ aliases { > >>>> =A0=A0+ serial1 =3D &uart1; > >>>> =A0=A0+ }; > >>>> =A0=A0+ > >>> > >>> =A0Is there any other UART in the system? > >> > >> =A0serial0 is defined in sun8i-reference-design-tablet.dtsi, as r_uart. > > > > If your board does not have r_uart pads, then the right thing to do > > would be to disable it. You can then have uart1 as serial0. >=20 > I don't know it. The RX/TX is wired on PF2/PF4 on the board (UART0 muxed = with > MMC) Then you don't support it and you need to disable it. > But many codes will require a ttyS0 as console... So I think the > bluetooth should be located at ttyS1... Most of them would use /dev/console anyway. What do you have in mind? Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --xB0nW4MQa6jZONgY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXvqZWAAoJEBx+YmzsjxAgDywP/0z0xE4A93WkCDFajH2Smc3e ItKmanSVQGKWVHiiiAimBPZMBSeybC2r48230uKMDr1UfYL4YPlOfSZdrvtvx0nN ybSHahet4M+Ltym1/R5UEbWou9u2+YEO5wR6rxXMkW1ALgfUyZvbPq+grwFMHkPt +ebvc/I/ELLHiYACO6nhlkdAi1+pB1MRTmOlBlqguXSilSfAhrHSNtSDJ3ZLeiX8 wJduLSiuWEAa3IT51k4Hte798P7cTGzOS0Ql2thqFWvVrPLV+rWg3Kvf9gvvDjg5 fwpgQagrT5/zKRjybhZQoBr1blk86COr/jruEOmOqyRu1L4o+cSwPOCJVSGWUxFg EAnjfnZwVAOvIrkDmrLaym5MzVdccTB81peLxHponii2IzG2j3EHuaVjZ2Yr3uHt xMpGaCaEGjVCsi9q+A0d3vqbE5caHxhMFZ/6uW7ZLbGZAyGimDxb7vmDvfZkvROh YgJ2iCCOxOnrF7ZV9t82+L7Tx8nlgpOx4YrtZuNGpBG6bUfajs7JvzjqrElnMUAC YvPsy/jK6a4X87PtBluuwuJCxNmei7ySXexHJqFhIxWXg0S7U/Ts+BvmjEr/kgcg YWUMJtCaK4OBI1u1EKB0YE7tYu32i1WlUDLLUud5XGuoozkHJQ08YdvAdTIeJ4ED 0XfWJTVMLEJggPg9bIjH =lYzw -----END PGP SIGNATURE----- --xB0nW4MQa6jZONgY--