Re: [PATCH] nvme: Fix nvme_get/set_features() with a NULL result pointer

Jens Axboe
2016-08-26T15:13:29Z

On 08/26/2016 09:17 AM, Keith Busch wrote:
> On Fri, Aug 26, 2016 at 04:35:57PM +0200, Christoph Hellwig wrote:
>> On Fri, Aug 26, 2016 at 07:31:33AM -0700, Andy Lutomirski wrote:
>>> - Consider *deleting* the SCSI translation layer's power saving code.
>>> It looks almost entirely bogus to me. It has an off-by-one in its
>>> NPSS handling, it hardcodes power state indices which is total BS, it
>>> ignores the distinction between operational and non-operational states
>>> (which I think matters for non-APST usage). It also seems likely to
>>> be that it's never been used, since it's one of the formerly
>>> crashy-looking set_features users.
>>
>> Please go ahead and send a patch to delete it. Adding the whole SCSI
>> layer was a mistake to start with, and it's always been horribly buggy.
>> Until I started running the libiscsi testsuite even fairly normal I/O
>> commands were a sure way to crash it, and crazy things like PM are
>> almost guaranteed to a) not actually be used by real application and
>> b) horrible buggy (as you've already noticed)
>
> Ack. If no distros or tools rely on the the SCSI crutch anymore, then
> by all means, let's delete it. It's been disabled default for a while
> now, and I think/hope everyone we care about has since migrated to
> nvme awareness.

On the FB management front, we don't depend on it. The only case that
has come up where it was needed, was some Intel closed tool ;-)

--
Jens Axboe