From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933905AbcHYMRL (ORCPT ); Thu, 25 Aug 2016 08:17:11 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:33531 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933848AbcHYMRJ (ORCPT ); Thu, 25 Aug 2016 08:17:09 -0400 Date: Thu, 25 Aug 2016 14:15:46 +0200 From: LABBE Corentin To: PrasannaKumar Muralidharan Cc: olof@lixom.net, mpm@selenic.com, herbert@gondor.apana.org.au, linuxppc-dev@lists.ozlabs.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hwrng: pasemi_rng.c: Migrate to managed API Message-ID: <20160825121546.GA25650@Red> References: <1472124856-12767-1-git-send-email-prasannatsmkumar@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1472124856-12767-1-git-send-email-prasannatsmkumar@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 25, 2016 at 05:04:16PM +0530, PrasannaKumar Muralidharan wrote: > Use devm_ioremap and devm_hwrng_register instead of ioremap and > hwrng_register. This removes unregistering and error handling code. > > This patch is not tested with hardware as I don't have access to it. > > Signed-off-by: PrasannaKumar Muralidharan > --- > drivers/char/hw_random/pasemi-rng.c | 26 +++----------------------- > 1 file changed, 3 insertions(+), 23 deletions(-) > > diff --git a/drivers/char/hw_random/pasemi-rng.c b/drivers/char/hw_random/pasemi-rng.c > index 699b725..0f03397 100644 > --- a/drivers/char/hw_random/pasemi-rng.c > +++ b/drivers/char/hw_random/pasemi-rng.c > @@ -100,37 +100,18 @@ static int rng_probe(struct platform_device *ofdev) > void __iomem *rng_regs; > struct device_node *rng_np = ofdev->dev.of_node; > struct resource res; > - int err = 0; > > - err = of_address_to_resource(rng_np, 0, &res); > - if (err) > + if (of_address_to_resource(rng_np, 0, &res)) > return -ENODEV; > > - rng_regs = ioremap(res.start, 0x100); > - > + rng_regs = devm_ioremap(&ofdev->dev, res.start, 0x100); > if (!rng_regs) > return -ENOMEM; > I will propose to use devm_ioremap_resource() instead for removing this hardcoded 0x100, but i cannot find any user of this driver in any dts. (And so cannot check that this 0x100 is given in any DT resource node) Is this normal ? Regard