From: Jiri Olsa <jolsa@redhat.com>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@redhat.com, acme@kernel.org,
alexander.shishkin@linux.intel.com, wangnan0@huawei.com,
hemant@linux.vnet.ibm.com, naveen.n.rao@linux.vnet.ibm.com,
mpetlan@redhat.com
Subject: Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization
Date: Thu, 25 Aug 2016 15:59:43 +0200 [thread overview]
Message-ID: <20160825135943.GB16482@krava> (raw)
In-Reply-To: <20160825215004.11182efd6f5309cd3af5a3fe@kernel.org>
On Thu, Aug 25, 2016 at 09:50:04PM +0900, Masami Hiramatsu wrote:
SNIP
> > After applying patch:
> >
> > $ ./perf probe -x ./test 'foo i'
> > $ cat /sys/kernel/debug/tracing/uprobe_events
> > p:probe_test/foo /home/ravi/test:0x0000000000000541 i=-4(%bp):s32
> >
> > $ ./perf record -e probe_test:foo ./test
> > $ ./perf script
> > test 6300 [001] 5877.879327: probe_test:foo: (400541) i=42
> >
> > No need to skip prologue for optimized case since debug info is correct
> > for each instructions for -O2 -g. For more details please visit:
> > https://bugzilla.redhat.com/show_bug.cgi?id=612253#c6
> >
> > Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
>
> Looks good for me:)
>
> Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
>
> Jiri, Michael, please try this. Ravi's patch can fix your problem.
yes, that fixes the problem for me
thanks a lot,
jirka
next prev parent reply other threads:[~2016-08-25 13:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 8:58 [PATCH 1/2] perf probe: Helper function to check if probe with variable Ravi Bangoria
2016-08-03 8:58 ` [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization Ravi Bangoria
2016-08-13 13:45 ` Ravi Bangoria
2016-08-25 12:30 ` Masami Hiramatsu
2016-08-18 9:17 ` Naveen N. Rao
2016-08-25 12:50 ` Masami Hiramatsu
2016-08-25 13:59 ` Jiri Olsa [this message]
2016-08-25 15:17 ` Arnaldo Carvalho de Melo
2016-08-25 15:44 ` Jiri Olsa
2016-08-26 19:30 ` Arnaldo Carvalho de Melo
2016-08-26 19:54 ` Arnaldo Carvalho de Melo
2016-08-27 0:27 ` Masami Hiramatsu
2016-08-29 15:10 ` [PATCH] perf probe: Move dwarf specific functions to dwarf-aux.c Ravi Bangoria
2016-08-29 22:53 ` Masami Hiramatsu
2016-08-30 8:39 ` [PATCH v2] " Ravi Bangoria
2016-08-30 14:10 ` Masami Hiramatsu
2016-09-05 13:27 ` [tip:perf/core] " tip-bot for Ravi Bangoria
2016-08-29 8:09 ` [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization Ravi Bangoria
2016-08-29 8:08 ` Ravi Bangoria
2016-09-05 13:26 ` [tip:perf/core] " tip-bot for Ravi Bangoria
2016-08-25 12:32 ` [PATCH 1/2] perf probe: Helper function to check if probe with variable Masami Hiramatsu
2016-09-05 13:26 ` [tip:perf/core] perf probe: Add helper " tip-bot for Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160825135943.GB16482@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=hemant@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=mpetlan@redhat.com \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.vnet.ibm.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox