Re: [RFC PATCH 2/4] perf-probe: Add offline output directory option

Masami Hiramatsu
2016-08-25T10:56:16Z

On Wed, 24 Aug 2016 09:58:45 -0300
Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

>
> Also please fix the OPT_STRING string, it should start with a capital
> letter:
>
> --max-probes <n> Set how many probe points can be found for a probe.
> --no-inlines Don't search inlined functions
> --outdir <directory>
> path to offline output directory
> --range Show variables location range in scope (with --vars only)
>
>
> See how it stands out? All the others start with a capital letter.

BTW, actually in most case, perf shows option explanations start without a captal letter,

./perf lock

Usage: perf lock [<options>] {record|report|script|info}

-D, --dump-raw-trace dump raw trace in ASCII
-i, --input <file> input file name
-v, --verbose be more verbose (show symbol address, etc)

etc. Some commands (including probe) mixing it...

Thanks,

--
Masami Hiramatsu <mhiramat@kernel.org>