From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760000AbcHYPoj (ORCPT ); Thu, 25 Aug 2016 11:44:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53000 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758242AbcHYPoh (ORCPT ); Thu, 25 Aug 2016 11:44:37 -0400 Date: Thu, 25 Aug 2016 17:44:33 +0200 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Masami Hiramatsu , Ravi Bangoria , linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, wangnan0@huawei.com, hemant@linux.vnet.ibm.com, naveen.n.rao@linux.vnet.ibm.com, mpetlan@redhat.com Subject: Re: [PATCH v2 2/2] perf uprobe: Skip prologue if program compiled without optimization Message-ID: <20160825154433.GA26071@krava> References: <1470214725-5023-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <1470214725-5023-2-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <20160825215004.11182efd6f5309cd3af5a3fe@kernel.org> <20160825135943.GB16482@krava> <20160825151753.GG10063@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160825151753.GG10063@kernel.org> User-Agent: Mutt/1.7.0 (2016-08-17) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 25 Aug 2016 15:44:36 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 25, 2016 at 12:17:53PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Aug 25, 2016 at 03:59:43PM +0200, Jiri Olsa escreveu: > > On Thu, Aug 25, 2016 at 09:50:04PM +0900, Masami Hiramatsu wrote: > > > > SNIP > > > > > > After applying patch: > > > > > > > > $ ./perf probe -x ./test 'foo i' > > > > $ cat /sys/kernel/debug/tracing/uprobe_events > > > > p:probe_test/foo /home/ravi/test:0x0000000000000541 i=-4(%bp):s32 > > > > > > > > $ ./perf record -e probe_test:foo ./test > > > > $ ./perf script > > > > test 6300 [001] 5877.879327: probe_test:foo: (400541) i=42 > > > > > > > > No need to skip prologue for optimized case since debug info is correct > > > > for each instructions for -O2 -g. For more details please visit: > > > > https://bugzilla.redhat.com/show_bug.cgi?id=612253#c6 > > > > > > > > Signed-off-by: Ravi Bangoria > > > > > > Looks good for me:) > > > > > > Acked-by: Masami Hiramatsu > > > > > > Jiri, Michael, please try this. Ravi's patch can fix your problem. > > > > yes, that fixes the problem for me > > Ok, so I'll add a Tested-by: Jiri, ok? And push it via perf/urgent. yep, thanks jirka