From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1760075AbcHYQKR (ORCPT <rfc822;w@1wt.eu>);
        Thu, 25 Aug 2016 12:10:17 -0400
Received: from mail-it0-f67.google.com ([209.85.214.67]:32928 "EHLO
        mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751530AbcHYQKO (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 25 Aug 2016 12:10:14 -0400
Date: Thu, 25 Aug 2016 12:09:23 -0400
From: Anson Jacob <ansonjacob.aj@gmail.com>
To: Andrey Utkin <andrey_utkin@fastmail.com>
Cc: gregkh@linuxfoundation.org, abbotti@mev.co.uk,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] staging: comedi: ni_at_a2150.c: Fix checkpatch
 warning
Message-ID: <20160825160923.GA6998@X250>
References: <cover.1472100602.git.ansonjacob.aj@gmail.com>
 <b2cf771e244dce8e6b2c40020b637b1fed66f8cd.1472100602.git.ansonjacob.aj@gmail.com>
 <20160825154708.a55hsffnfdz2zqac@acer>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160825154708.a55hsffnfdz2zqac@acer>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thank you for your comments.

On Thu, Aug 25, 2016 at 06:47:08PM +0300, Andrey Utkin wrote:
> 
> > +#define CHANNEL_BITS(x)		((x) & 0x7)
> > +#define CHANNEL_MASK		0x7
> 
> No uniform alignment. Please get everything in a row.
> If it's hard or this part of driver is expected to have a lot of changes
> in near future, then I'd remove any whitespace over single space between
> name and value.
>

I didn't get your point in this case. Could you explain it.