From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760774AbcHYQvm (ORCPT ); Thu, 25 Aug 2016 12:51:42 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:33728 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760067AbcHYQvk (ORCPT ); Thu, 25 Aug 2016 12:51:40 -0400 Date: Thu, 25 Aug 2016 22:20:55 +0530 From: Sudip Mukherjee To: Ming-Chia Chung Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Andy Whitcroft , Joe Perches Subject: Re: [PATCH] staging: rts5208: rtsx.c: Fix checkpatch warnings. Message-ID: <20160825165054.GA5345@sudip-laptop> References: <20160822165417.GA39631@Qsphere.local> <20160822172127.GA29160@sudip-laptop> <20160823001946.GA78290@Qsphere.local> <20160823063136.GA17729@sudip-laptop> <20160825135946.GA20573@59-127-50-234.hinet-ip.hinet.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160825135946.GA20573@59-127-50-234.hinet-ip.hinet.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 25, 2016 at 09:59:46PM +0800, Ming-Chia Chung wrote: > On Tue, Aug 23, 2016 at 12:01:36PM +0530, Sudip Mukherjee wrote: > > On Tue, Aug 23, 2016 at 08:19:46AM +0800, Ming-Chia Chung wrote: > > > On Mon, Aug 22, 2016 at 10:51:27PM +0530, Sudip Mukherjee wrote: > > > > On Tue, Aug 23, 2016 at 12:54:17AM +0800, MingChia Chung wrote: > > > > > This patch fixes a minor checkpatch warnings: > > > > > > > > > > "WARNING: Block comments use a trailing */ on a separate line" > > > > > > > > > > Signed-off-by: Ming-Chia Chung > > > > > --- > > > > > drivers/staging/rts5208/rtsx.c | 42 ++++++++++++++++++++++++++++-------------- > > > > > 1 file changed, 28 insertions(+), 14 deletions(-) > > > > > > > > > > diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c > > > > > index e992e03..a880411 100644 > > > > > --- a/drivers/staging/rts5208/rtsx.c > > > > > +++ b/drivers/staging/rts5208/rtsx.c > > > > > @@ -81,14 +81,16 @@ static int slave_alloc(struct scsi_device *sdev) > > > > > > > > > > static int slave_configure(struct scsi_device *sdev) > > > > > { > > > > > - /* Scatter-gather buffers (all but the last) must have a length > > > > > + /* > > > > > + * Scatter-gather buffers (all but the last) must have a length > > > > > > > > The alignment doesnot look correct here. Also in some more places later > > > > in this patch. > > > > > > > > regards > > > > Sudip > > > > > > I sent this patch by following docs ([1] and [2]). The style for long > > > comments needs the begining and ending almost-blank lines. There is no > > > the begining almost-blank line only for the files in net/ and > > > drivers/net/. > > > Please let me know what I misunderstood. > > > > After applying the patch the file was like: > > /* > > * Scatter-gather buffers (all but the last) must have a length > > * divisible by the bulk maxpacket size. Otherwise a data packet > > * would end up being short, causing a premature end to the data > > * transfer. Since high-speed bulk pipes have a maxpacket size > > > > See the alignment of the second line. Please use tab instead of space. And also > > checkpatch should have warned you not to use space before the Signed-off-by. > > > > Thank you for detailed explanation. I enabled "expandtab" in vim so that > I didn't realize the alignment is wrong. Now, I install 'linuxsty.vim' > to view the code. But checkpatch.pl didn't show the warning of space. > Here is my command: > `kernels/staging$ perl scripts/checkpatch.pl -f drivers/staging/rts5208/rtsx.c` Please run checkpatch on your patch and it will show you the warning about space before Signed-off-by. But it missed the place where space was used inplace of tab. Maybe you can send a patch to fix checkpatch. Added Cc: to Joe and Andy. regards sudip