From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933099AbcHYUq6 (ORCPT ); Thu, 25 Aug 2016 16:46:58 -0400 Received: from mail-co1nam03on0127.outbound.protection.outlook.com ([104.47.40.127]:63408 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757363AbcHYUqz (ORCPT ); Thu, 25 Aug 2016 16:46:55 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=zach.brown@ni.com; Date: Thu, 25 Aug 2016 15:46:45 -0500 From: Zach Brown To: Mark Rutland CC: , , , , , , , , , Subject: Re: [PATCH 1/2] sdhci-of-arasan: Add quirk and device tree parameter to fake CD bit Message-ID: <20160825204645.GA19450@zach-desktop> References: <1472080984-17373-1-git-send-email-zach.brown@ni.com> <20160825105640.GA5439@remoulade> <20160825171539.GA13571@zach-desktop> <20160825180959.GA14705@remoulade> <20160825182621.GA14817@zach-desktop> <20160825182852.GB15000@remoulade> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160825182852.GB15000@remoulade> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [130.164.62.11] X-ClientProxiedBy: BY1PR14CA0028.namprd14.prod.outlook.com (10.161.91.38) To DM2PR0401MB1455.namprd04.prod.outlook.com (10.160.222.23) X-MS-Office365-Filtering-Correlation-Id: 56417a97-932d-4a3b-3750-08d3cd28f127 X-Microsoft-Exchange-Diagnostics: 1;DM2PR0401MB1455;2:OQiGtOJMzHIoWn+NntY0TGGKhQoRxGLmSBG+Cb/cTwRkle12ZGJLvjsAuFnwtbkHUNRiXjQoLsn0Xu8xQ5eXkGGDem+RDhrpcz88cV78jW116BVQy6/QXpiHUI7Hn3ho1ckfU+fHam+3i/6dz/0/jlaOV2bIOD5HbmFXu67MGS9VMn2a+ZbQFnnE/tqY289s;3:BTjnPmKuZ12ScAja2mtjyp/h2/REpHsaAEdpIo/p5Jxufb9x8LsJgpFPEsqt7hGebk9u6qT2Qy3x+SSYdhoRufnPY4AE+1ecn8u6vTGyNlflUc2J8Xu8bua1dGmEDOTW;25:SjkZPIwJVdf0+VKDhpYqXPOlfWqRv7fCG6wcr6xaulPdUcXvJrt9jltRO93xVfpUqAQGaWnd1CRqULPMDp2j66p9Srtgn+LMVBUMoVeIzUs9ABgmnstQhMfdPZK4coeDchFuH4h2gKhbnkTIXjkoLuaDbKqf5Fa+8icNaNhurkClHf8Y5iL0PM5Vr8wwtM7T0KxBpG1dgF4JjZAljW/yKWWlTGw7POFp5kuWcxZVwVvDyyJrmO1FiLyOAMJV4YpYVbW9hopKW1hY/n7gQaeXoeS/GcAXSfpx2PeFHMw36LBIKszFN/HhfD3BDv4JzPkBuvxJhm3vDcI2rzkD9rnHAVTlK/tngDdu6cD4VyU6uzrfP8zL2Fs5yZ1oe8GSULFPcCqzfbVDo0U1gpcxq4hn7Qi4nqzg0r56fnWqcRDPKKE= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0401MB1455; X-Microsoft-Exchange-Diagnostics: 1;DM2PR0401MB1455;31:I0Rr9OagdA0bY/CVEmdpLGKaduTfcgpMGEUnQo8VCBw7wejOtL7p6o4fzkmJYY1ugH8QkjPe4pdtmFsQDMUnO5gfB9CBXCnI3R59FxTcKOZAibd9pAJq+P1ai3KzVWbAYvBzbiSNAUi47ax7CEiwBGskOtWXjX2SPPvmGEdiplIDNtdC9eyki7jNZxUyxs9jNWWyovd4yrJLI44eAQfZm/XijwpirccBCqnrE4wRIfA=;20:Don9BZYfmOuQgtBjtfFQXb2eXqIpnSOnP2obx6Wzg/ztYrs/HeQqvIa89IntzyyxCiY0w0DD4NkdUJl3pgv468mdo/+Mh/i+2HA3VkTiBZ3TQ2a9bx1eGlZgF4v+QwpD3I0cBBEQCRSjL0BR30WxkVrnT8F7NyzoYt0a9lrKAJbRmaa0vBcQciQYTp+qGt33R5DRe5Fydi2iwhMRK1674MYc95U1j/4QMFO2pBRwxcM4BiPZBgDbyKSEJtKvFVSEt8Lmz3uqw9/n9eT/Xt++Bd4Xm5CJVeGqo+Aq3Fn2UFZf5nymYrIOcXfxV/kJ0Zb4/XHnSI/XtQKQW6U4IHI8m7X2rnt6oeUxJEmNV4o034nsdHjz+nSoQrASj/GDhpTM8Uxm45yUSLFXYxN3PhAWvVDSXAgHOeTSoffLZOMAb5iyjW/h8OgdfXxyl70AIe5dgkDSXzdmLN4CZTZxmorWSM9BE65AUZr+k8Vb8BZaNc0uOxefascTVREm/iNt5vgv7e7dZpAZOxygr+OnxJNmV14E2Pm/2F3cu2dnXcnj34iiiHk3OjmDfWzKlFRV0RCziGAqKYM0X1/sYjJwaXcPlqWxhp1zuPieyUIM9JQGzo0= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:DM2PR0401MB1455;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0401MB1455; X-Microsoft-Exchange-Diagnostics: 1;DM2PR0401MB1455;4:JROgj0mwqxNffmbc+dWFjgNG+JIFC/Utkei6BfYfDl/BJMUkthVHaW6bGof9kA4Kg7wFXEk0wqBTf8APHm4YITxG5ShhnOsWwOgkRNQok7GCfgmgAujwcWwtpho2iVXIF9cqzcZZ/6emyn3zvPp36OyOCf2uCpgEBNQYE68Nl7XYmFPMmlzOIv99wgxaxLiu4xJvALWKjidWKVwS80FSxRMUlF0tE52sldSFEbA/9MAKUgmaL5naYk4XLuvUl/qq38/WOI+11oalpKIZL4Hs+FPf7uBhJdb4aumrMCXPAT1MzrVHojgHUYBPvbhtLLy9Nf52RVUDmM18mXkadyccyxKMu0Jh6tFZ6OOREKsLC/mEnZFF8OhrUHGu81VbXmSPeUX19az/ZBa5bP8S1JSOpg== X-Forefront-PRVS: 0045236D47 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(189002)(51444003)(52314003)(199003)(24454002)(47776003)(77096005)(33656002)(189998001)(110136002)(4001350100001)(97736004)(42186005)(8666005)(7416002)(101416001)(106356001)(105586002)(5660300001)(66066001)(92566002)(93886004)(1076002)(68736007)(19580395003)(7846002)(97756001)(76176999)(54356999)(50986999)(23726003)(50466002)(83506001)(81156014)(4326007)(8676002)(86362001)(81166006)(6116002)(3846002)(586003)(230783001)(2950100001)(2906002)(305945005)(33716001)(9686002)(7736002)(46406003)(18370500001)(7059030)(107986001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM2PR0401MB1455;H:zach-desktop;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM2PR0401MB1455;23:PRVjavJnZFrjMfLOrJ/oq81e8peeFyHYZmwmPoA?= =?us-ascii?Q?KJ18kOGF+lD0AFCJkgk3vyyZHvd9+4Fyt1CInzpknlIPiYNOmfvQyokLlQSp?= =?us-ascii?Q?RQr6eKufrjlj+Dyw55XNz0DHrgl/7Ev2BKmNt6BJBDlezzPOVf/UQWGtoJt6?= =?us-ascii?Q?DrilZOtYvfvfLPIRavvmmrrHreGhhUo44D62D0jqz8du2wXhbVSei0EQLPIQ?= =?us-ascii?Q?mIOTWaUpdHSCWGda88etGm+hkTZlVBraU6mCkgRD83afPppHxyctrd0eazdq?= =?us-ascii?Q?P1aXHCfIKqL1puSW1//Tv+jIdTRo9uGMZmBceUsJs5MUtnnk4qliqo4z6Ko2?= =?us-ascii?Q?4R5DGFLjRXrlxe9kUclUVZu3dbKwgGFR/eCcu+cnvT12cg/1I1zO7/rRkb2D?= =?us-ascii?Q?m0sjpod1IA+xfGvkPWLN01gUPlpk3PgdOVjyxW8P379WeESXdmbEKehV8nHi?= =?us-ascii?Q?cLXNnKXb1RTAuP3j1xu5eSsg3NJ/QQpzVtBRrp9gYU8OUrg+wHgP1c9mqivR?= =?us-ascii?Q?56VhoPJR9J5fEN2Kha1LvdAc/9XTYNFVDmGqUAPfPXcH1NUkX8ADu8PVv7tr?= =?us-ascii?Q?5uqwMxVc7LWHtHWjJXzjcdHejcoTZhanLjNFonuZHvHoeEcdJX0x3LOFZg1J?= =?us-ascii?Q?4/R/HYdHRr6jVNs1QsNpMRYoVhiH06E5xbctZeawtktLAsRSJxp3scvTdi2o?= =?us-ascii?Q?xlFAHxj7jByprLbjLNFYCN7HZFglg+i85dmPTrrNmqEWbJkczTulfdcZys2L?= =?us-ascii?Q?9vm6e/1m7ueqzMtYP5ziNmhICZBTnITOr3UaUPkcDlzQfQIg4Ndtuz3v7Jja?= =?us-ascii?Q?X98p3+1nNfBMuu086CecxvJomQJAXDH5xTmGqr+YicskBj1iscDfpezX4HR3?= =?us-ascii?Q?qG2rLdUcMqRSMlGyTT244dLiETHakZFCV7fU1fONe//B/6v1eEXtqOvO9O1/?= =?us-ascii?Q?30k+j7TIDcpnmk7tidwEB1PXZhqYEoYYpOZW/FtPoUxOJFGP3NkoVAY3FLw2?= =?us-ascii?Q?/VU2ZHZsmbGbPp6vfyUfGBRt44QVlV5JzNI1FJiFYX19Pdv+YVH/zcMepWE9?= =?us-ascii?Q?Kh+4Smdbuh2USoN8jZjLOH5jTOqwjEhMRFB0ANTCyz8TYMt+3uumHTbdDyiV?= =?us-ascii?Q?QkwZtzo5mTsNJbANONdU7EFpofJYsXlJM2ARZUOzx0rMFWp1T+3pl41EsOlv?= =?us-ascii?Q?+WdjcFo/VlKqVIY6meSk6v4dkglVrPM0h8LrAzapejRfbILx817EdlfU+jL5?= =?us-ascii?Q?H+EgLKtkqdjI0ahPvgEX9H7Yz6Z37yiKUgrRY1ffaJXROAZnurfV5GTzneHM?= =?us-ascii?Q?lfD3dKCT6Lk8CwF8AVwHxq0U=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM2PR0401MB1455;6:vWm/KD6xEjDDgKalcvKUMjKdfj1fSML/Mz5qm+FhpYfb7MRoaPNscwknvwUmsm3VuFZIDLJQQg2+EF5CGhpZD7kXHCxvviNpVUb7Q2/ykucUkLFK29hbPK+XNE0uv42uwhKh3bNXJnoG2K4oKdRqTD0vQec/LoeLg9mojjYPclfQcag7PXAFgmKQX+hUZZPEWmUrIVucOmbjhHKlGK6dyJLvJklHle+TOW1SZ+Jd2X92mpgZV7EKxUDjzroWl/bWegYCr3voxS8uB2AVNUUHL4DoDxl7MNvclIjkZgDey8Q=;5:kr0vUG+pvxuTft7AlhLASaW/+imY4Rz3lC0nCARFPJXYK0pxeaA0cIhweQ+OoapB1tnwb13TxEj/SMq9Ndk2ava4IR1y50nIJV9yR8KsTUAipRu4gDARBWZMNgqIRIfsMSWCrBU/IITch4bjujCwQA==;24:3Q5Zrpl/0AlsauyfAAcamub/ziGf7Zj/I3bm/TH7JhRs1TxGGZ9RLn4VA0EouRnM/51GtBi6Zg9EyuNb0X96Si+bM3V+rRR9vhbgBQGc0qM=;7:4Whdw0Y6v0Q4gaW4BbsbyRqlug/rvWI03vDgkqNmDTFhqXqllP9K2weTCwWC+vQ2UVJC6FzMxlwoLdgszmNBMlfCtea3qWOo3zK7ir5NmNKM1khPm5EkT1pmET8cezyhvFbtEevDDW9U1BClj8NfhXedMgb4ylRwpPNoKcPz+VTQWeop6kkjn1XyT5KTUeAKALr7VKOxmnWFjuXjnJ9ZdbBZCCMNpCleibJRhUpJnnQgnwU2b5M8cMMJiWN9ne0L SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: ni.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Aug 2016 20:46:50.6498 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0401MB1455 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 25, 2016 at 07:28:55PM +0100, Mark Rutland wrote: > On Thu, Aug 25, 2016 at 01:26:22PM -0500, Zach Brown wrote: > > On Thu, Aug 25, 2016 at 07:10:00PM +0100, Mark Rutland wrote: > > > On Thu, Aug 25, 2016 at 12:15:44PM -0500, Zach Brown wrote: > > > > In cases where the card is non-removable then polling doesn't make sense. > > > > > > We have the non-removable property to describe that, so we can also look at that. > > > > > > > So it doesn't make sense to tie the test mode workaround into the broken-cd > > > > property, even though I agree the nature of the defect fits under the notion > > > > of the CD being broken. > > > > > > Maybe not solely on broken-cd, but I think that we dont necessarily need a new > > > DT property. As above, broken-cd, non-removable, and the compatible string may > > > together give the kernel enough information to choose the right thing to do. > > > > > > Thanks, > > > Mark. > > > > I'm not sure if I understand your suggestion completely. Are you suggesting > > setting both the broken-cd and non-removable properties? That would make sense, > > but my understanding was that the two properities are not meant to co-exist. In > > /Documentation/devicetree/bindings/mmc/mmc.txt it states that only one should > > be supplied. Don't the two properties conflict with each other? > > They do for the cases that exist today, but given we're updating the document > anyway, we could simply clarify the cases in which the two can sanely co-exist > (e.g. for this particular IP block). > > Thanks, > Mark. That makes sense. I'll change the documentation for broken-cd and non-removable in the IP specific document and change the driver accordingly.