From: Oleg Nesterov <oleg@redhat.com>
To: Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
Bart Van Assche <bvanassche@acm.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Neil Brown <neilb@suse.de>,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] sched/wait: abort_exclusive_wait() should pass TASK_NORMAL to wake_up()
Date: Fri, 26 Aug 2016 14:44:53 +0200 [thread overview]
Message-ID: <20160826124453.GA28894@redhat.com> (raw)
To clarify, this can't fix the lock_page() hang reported by Bart,
__wait_on_bit_lock() is fine even if abort_exclusive_wait() is buggy.
Still should be fixed I think. And perhaps we should simply kill
abort_exclusive_wait() ? See 2/2.
And this reminds me... I still fail to understand why/how the commit
68985633bccb60 "sched/wait: Fix signal handling in bit wait helpers"
can help. Apart from s/return 1/return -EINTR/. Peter, do you have any
theory?
Oleg.
next reply other threads:[~2016-08-26 12:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-26 12:44 Oleg Nesterov [this message]
2016-08-26 12:45 ` [PATCH 1/2] sched/wait: abort_exclusive_wait() should pass TASK_NORMAL to wake_up() Oleg Nesterov
2016-09-01 11:39 ` Peter Zijlstra
2016-09-01 17:26 ` Oleg Nesterov
2016-09-01 18:09 ` Peter Zijlstra
2016-08-26 12:45 ` [PATCH 2/2] sched/wait: avoid abort_exclusive_wait() in __wait_on_bit_lock() Oleg Nesterov
2016-08-26 12:47 ` Oleg Nesterov
2016-09-01 19:01 ` Peter Zijlstra
2016-09-01 19:08 ` Peter Zijlstra
2016-09-02 12:06 ` Oleg Nesterov
2016-09-01 22:17 ` Peter Zijlstra
2016-09-02 12:06 ` Oleg Nesterov
2016-09-02 13:20 ` Peter Zijlstra
2016-09-02 12:06 ` Oleg Nesterov
2016-09-01 11:03 ` [PATCH 0/2] sched/wait: abort_exclusive_wait() should pass TASK_NORMAL to wake_up() Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160826124453.GA28894@redhat.com \
--to=oleg@redhat.com \
--cc=bvanassche@acm.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=neilb@suse.de \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).