From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753751AbcHZMyq (ORCPT <rfc822;w@1wt.eu>);
        Fri, 26 Aug 2016 08:54:46 -0400
Received: from mx1.redhat.com ([209.132.183.28]:40136 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753718AbcHZMyo (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 26 Aug 2016 08:54:44 -0400
Date: Fri, 26 Aug 2016 14:44:53 +0200
From: Oleg Nesterov <oleg@redhat.com>
To: Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
        Bart Van Assche <bvanassche@acm.org>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Neil Brown <neilb@suse.de>, linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] sched/wait: abort_exclusive_wait() should pass
 TASK_NORMAL to wake_up()
Message-ID: <20160826124453.GA28894@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.24 (2015-08-30)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 26 Aug 2016 12:44:56 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

To clarify, this can't fix the lock_page() hang reported by Bart,
__wait_on_bit_lock() is fine even if abort_exclusive_wait() is buggy.

Still should be fixed I think. And perhaps we should simply kill
abort_exclusive_wait() ? See 2/2.


And this reminds me... I still fail to understand why/how the commit
68985633bccb60 "sched/wait: Fix signal handling in bit wait helpers"
can help. Apart from s/return 1/return -EINTR/. Peter, do you have any
theory?

Oleg.