From: Christoph Hellwig <hch@lst.de>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Jens Axboe <axboe@fb.com>,
linux-nvme@lists.infradead.org,
Keith Busch <keith.busch@intel.com>,
Christoph Hellwig <hch@lst.de>, stable <stable@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nvme: Fix nvme_get/set_features() with a NULL result pointer
Date: Fri, 26 Aug 2016 16:35:57 +0200 [thread overview]
Message-ID: <20160826143557.GA21788@lst.de> (raw)
In-Reply-To: <CALCETrV+ndPPGhoO5zwQWC5knvrRF8NKtk2hx0CgCqg60=vGmQ@mail.gmail.com>
On Fri, Aug 26, 2016 at 07:31:33AM -0700, Andy Lutomirski wrote:
> - Consider *deleting* the SCSI translation layer's power saving code.
> It looks almost entirely bogus to me. It has an off-by-one in its
> NPSS handling, it hardcodes power state indices which is total BS, it
> ignores the distinction between operational and non-operational states
> (which I think matters for non-APST usage). It also seems likely to
> be that it's never been used, since it's one of the formerly
> crashy-looking set_features users.
Please go ahead and send a patch to delete it. Adding the whole SCSI
layer was a mistake to start with, and it's always been horribly buggy.
Until I started running the libiscsi testsuite even fairly normal I/O
commands were a sure way to crash it, and crazy things like PM are
almost guaranteed to a) not actually be used by real application and
b) horrible buggy (as you've already noticed)
next prev parent reply other threads:[~2016-08-26 14:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 10:52 [PATCH] nvme: Fix nvme_get/set_features() with a NULL result pointer Andy Lutomirski
2016-08-24 11:04 ` Sagi Grimberg
2016-08-24 14:11 ` Jens Axboe
2016-08-25 7:38 ` Christoph Hellwig
2016-08-25 7:54 ` Andy Lutomirski
2016-08-25 8:27 ` Christoph Hellwig
2016-08-25 14:20 ` Jens Axboe
2016-08-26 14:31 ` Andy Lutomirski
2016-08-26 14:35 ` Christoph Hellwig [this message]
2016-08-26 15:17 ` Keith Busch
2016-08-26 15:12 ` Jens Axboe
2016-08-26 15:06 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160826143557.GA21788@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=luto@amacapital.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox