From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753208AbcHZNtE (ORCPT <rfc822;w@1wt.eu>);
        Fri, 26 Aug 2016 09:49:04 -0400
Received: from mout.kundenserver.de ([217.72.192.73]:57254 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752930AbcHZNtB (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 26 Aug 2016 09:49:01 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] ARM: imx: add SMP support for i.MX7D
Date: Fri, 26 Aug 2016 15:48:08 +0200
User-Agent: KMail/1.12.2 (Linux/4.7.0-rc7+; KDE/4.3.2; x86_64; ; )
Cc: Yongcai Huang <anson.huang@nxp.com>,
        "Russell King - ARM Linux" <linux@armlinux.org.uk>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        Fabio Estevam <fabio.estevam@nxp.com>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>
References: <1472209971-32469-1-git-send-email-Anson.Huang@nxp.com> <20160826111356.GM1041@n2100.armlinux.org.uk> <AM3PR04MB13154FA0116D397AABD75E10F5EC0@AM3PR04MB1315.eurprd04.prod.outlook.com>
In-Reply-To: <AM3PR04MB13154FA0116D397AABD75E10F5EC0@AM3PR04MB1315.eurprd04.prod.outlook.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201608261548.08227.arnd@arndb.de>
X-Provags-ID: V03:K0:9fW9st3gde8k3UekoZT2eoagpqeDJD3I++BrMoCfxP4ji+6+hf1
 IibqNuiXIuMjRWQxvBpPsoLaepfG2JlCB1nhcSYd9gH31M07M3X6MipuSiP7fLenBMDhWER
 3iFicbMDu57tKpC5b+9pjotBtWlMCqwJ6JcSizvQeMPlJgv9WbWlmieN/3Rhp3w/6fRrMsL
 s3J5QxjU8FjkyhWpJx+ow==
X-UI-Out-Filterresults: notjunk:1;V01:K0:SI5LK0/GnX8=:l3Lm1RuYeu8woS+nQ87aec
 wQ7XjQmbEtUX+EoROSxPK/9Pr2sf0zWFKrL1gEb56ZqYrZq/7HGKexVyX795kLnP1DT977qYg
 C2696PziNwjEO1FCeuv1bFKRb9yKCq6O8i3dP2tDQ6+7Cf1wZEqtFlDULA65k090P9ywjdZGW
 xQw7rMjUv9U28HQ1rMzoBOTe2EykWF2WUXPb9VkoAqlSbzKimUDLD9eD6n+Bmc1vnyYb7e9AZ
 knczG8TYE0Bb7OMWlK5GVaVBVTiisT9sNWfuEphEWsRbyFmvjF5dIyJ5kIyMlaFU1M3gyxwBz
 wWGYXPjM339GVI6OKTitb5ftK2CEt9Xe8HMIEUFwyraVZh8SsAfs+5Z/bFLm5p7VfJaDlWxJ+
 GtfI1flHP7Hj1Fr75rDE5HfRi+gM5p+0vJiiEWLZ4/JyS42dXHA5PsYE8BaXjTQPMNWcYsp/N
 k9ceIgnvN0IOJXHnh1Q2ozy1S2taiVkSOaAf7AYv5X5LY6DDSzZGExvMipYtaxExbB27Rdf1H
 WAzo2qPVS0PPIZBnMcVNdJbctvGMItZRbQPBL6dCePqWeOT9PFblhBs9wSy9XD/gRrdS77fgN
 m0X6OXcyUwL7u7CQGaGaMzlYLQ+52+tCXev0gwUuPP/Fqj9OQMDVTNsghEyblEls5j2UjZP4l
 lmQeSea3a6psNHSFeZ7v6ByBbt3fAA77PShggzsIXL2FpUQD7YWvwSHSmk+/WGeA8ptJGdt9d
 7ioqHJPPYIFwwLOC
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Friday 26 August 2016, Yongcai Huang wrote:
> > 
> > It's about time iMX folk learned that "imx*" is a SoC and not a CPU.
> > It should be "soc_is_imx7d()" because we're wanting to know whether the
> > SoC is an iMX7D.  The CPU is a _Cortex-A7_.
> 
> Agree, I will add a new patch in this patch set to replace all the cpu_is_xxx with
> Soc_is_xxx.

I recently did a patch to remove all the cpu_is_mx{1,2,3,5}* macros, which ended up
making the code simpler and more readable in most places. I think we can
do the same for the cpu_is_imx{6,7}* macros.

In this instance, the easy alternative is to have a separate smp_operation
structure for imx7d rather than using the same as imx6 and then figuring
out at runtime which one you have.

	Arnd