From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754471AbcHZQIR (ORCPT ); Fri, 26 Aug 2016 12:08:17 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:46543 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753592AbcHZQIN (ORCPT ); Fri, 26 Aug 2016 12:08:13 -0400 X-IBM-Helo: d03dlp01.boulder.ibm.com X-IBM-MailFrom: paulmck@linux.vnet.ibm.com Date: Fri, 26 Aug 2016 09:08:23 -0700 From: "Paul E. McKenney" To: Rik van Riel Cc: Arnd Bergmann , Kees Cook , Steven Rostedt , linux-kernel@vger.kernel.org Subject: Re: [PATCH] bug: avoid Kconfig warning for BUG_ON_DATA_CORRUPTION Reply-To: paulmck@linux.vnet.ibm.com References: <20160826154232.933432-1-arnd@arndb.de> <1472226423.2751.57.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1472226423.2751.57.camel@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16082616-0020-0000-0000-000009A542AE X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00005644; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000183; SDB=6.00750047; UDB=6.00354194; IPR=6.00522683; BA=6.00004676; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00012476; XFM=3.00000011; UTC=2016-08-26 16:08:10 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16082616-0021-0000-0000-000054ECA36A Message-Id: <20160826160823.GF19706@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-26_12:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608260210 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 26, 2016 at 11:47:03AM -0400, Rik van Riel wrote: > On Fri, 2016-08-26 at 17:42 +0200, Arnd Bergmann wrote: > > The CONFIG_DEBUG_LIST option is normally meant for kernel developers > > rather than production machines and is guarded by > > CONFIG_DEBUG_KERNEL. > > > > In contrast, the newly added CONFIG_BUG_ON_DATA_CORRUPTION is meant > > for security hardening and may be used on systems that intentionally > > do not enable CONFIG_DEBUG_KERNEL. In this configuration, we get > > a warning from Kconfig about the mismatched dependencies: > > > > warning: (BUG_ON_DATA_CORRUPTION) selects DEBUG_LIST which has unmet > > direct dependencies (DEBUG_KERNEL) > > > > This annotates the DEBUG_LIST option to be selectable by > > BUG_ON_DATA_CORRUPTION when DEBUG_KERNEL is disabled. > > > > Signed-off-by: Arnd Bergmann > > Fixes: 40cd725cfc7f ("bug: Provide toggle for BUG on data > > corruption") > > > Acked-by: Rik van Riel Queued for further review and testing, thank you both! I expect to push this into the upcoming merge window, given that it fixes a bug in my current stack of commits. Thanx, Paul