* [PATCH] bug: avoid Kconfig warning for BUG_ON_DATA_CORRUPTION
@ 2016-08-26 15:42 Arnd Bergmann
2016-08-26 15:47 ` Rik van Riel
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2016-08-26 15:42 UTC (permalink / raw)
To: Paul E . McKenney
Cc: Kees Cook, Steven Rostedt, Rik van Riel, Arnd Bergmann,
linux-kernel
The CONFIG_DEBUG_LIST option is normally meant for kernel developers
rather than production machines and is guarded by CONFIG_DEBUG_KERNEL.
In contrast, the newly added CONFIG_BUG_ON_DATA_CORRUPTION is meant
for security hardening and may be used on systems that intentionally
do not enable CONFIG_DEBUG_KERNEL. In this configuration, we get
a warning from Kconfig about the mismatched dependencies:
warning: (BUG_ON_DATA_CORRUPTION) selects DEBUG_LIST which has unmet direct dependencies (DEBUG_KERNEL)
This annotates the DEBUG_LIST option to be selectable by
BUG_ON_DATA_CORRUPTION when DEBUG_KERNEL is disabled.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 40cd725cfc7f ("bug: Provide toggle for BUG on data corruption")
---
lib/Kconfig.debug | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 6f5ca0530e47..dd40d4ad9063 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -1229,7 +1229,7 @@ config DEBUG_BUGVERBOSE
config DEBUG_LIST
bool "Debug linked list manipulation"
- depends on DEBUG_KERNEL
+ depends on DEBUG_KERNEL || BUG_ON_DATA_CORRUPTION
help
Enable this to turn on extended checks in the linked-list
walking routines.
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] bug: avoid Kconfig warning for BUG_ON_DATA_CORRUPTION
2016-08-26 15:42 [PATCH] bug: avoid Kconfig warning for BUG_ON_DATA_CORRUPTION Arnd Bergmann
@ 2016-08-26 15:47 ` Rik van Riel
2016-08-26 16:08 ` Paul E. McKenney
0 siblings, 1 reply; 3+ messages in thread
From: Rik van Riel @ 2016-08-26 15:47 UTC (permalink / raw)
To: Arnd Bergmann, Paul E . McKenney; +Cc: Kees Cook, Steven Rostedt, linux-kernel
On Fri, 2016-08-26 at 17:42 +0200, Arnd Bergmann wrote:
> The CONFIG_DEBUG_LIST option is normally meant for kernel developers
> rather than production machines and is guarded by
> CONFIG_DEBUG_KERNEL.
>
> In contrast, the newly added CONFIG_BUG_ON_DATA_CORRUPTION is meant
> for security hardening and may be used on systems that intentionally
> do not enable CONFIG_DEBUG_KERNEL. In this configuration, we get
> a warning from Kconfig about the mismatched dependencies:
>
> warning: (BUG_ON_DATA_CORRUPTION) selects DEBUG_LIST which has unmet
> direct dependencies (DEBUG_KERNEL)
>
> This annotates the DEBUG_LIST option to be selectable by
> BUG_ON_DATA_CORRUPTION when DEBUG_KERNEL is disabled.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 40cd725cfc7f ("bug: Provide toggle for BUG on data
> corruption")
>
Acked-by: Rik van Riel <riel@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] bug: avoid Kconfig warning for BUG_ON_DATA_CORRUPTION
2016-08-26 15:47 ` Rik van Riel
@ 2016-08-26 16:08 ` Paul E. McKenney
0 siblings, 0 replies; 3+ messages in thread
From: Paul E. McKenney @ 2016-08-26 16:08 UTC (permalink / raw)
To: Rik van Riel; +Cc: Arnd Bergmann, Kees Cook, Steven Rostedt, linux-kernel
On Fri, Aug 26, 2016 at 11:47:03AM -0400, Rik van Riel wrote:
> On Fri, 2016-08-26 at 17:42 +0200, Arnd Bergmann wrote:
> > The CONFIG_DEBUG_LIST option is normally meant for kernel developers
> > rather than production machines and is guarded by
> > CONFIG_DEBUG_KERNEL.
> >
> > In contrast, the newly added CONFIG_BUG_ON_DATA_CORRUPTION is meant
> > for security hardening and may be used on systems that intentionally
> > do not enable CONFIG_DEBUG_KERNEL. In this configuration, we get
> > a warning from Kconfig about the mismatched dependencies:
> >
> > warning: (BUG_ON_DATA_CORRUPTION) selects DEBUG_LIST which has unmet
> > direct dependencies (DEBUG_KERNEL)
> >
> > This annotates the DEBUG_LIST option to be selectable by
> > BUG_ON_DATA_CORRUPTION when DEBUG_KERNEL is disabled.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: 40cd725cfc7f ("bug: Provide toggle for BUG on data
> > corruption")
> >
> Acked-by: Rik van Riel <riel@redhat.com>
Queued for further review and testing, thank you both!
I expect to push this into the upcoming merge window, given that it
fixes a bug in my current stack of commits.
Thanx, Paul
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-26 16:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-26 15:42 [PATCH] bug: avoid Kconfig warning for BUG_ON_DATA_CORRUPTION Arnd Bergmann
2016-08-26 15:47 ` Rik van Riel
2016-08-26 16:08 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox