From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752794AbcHZTdL (ORCPT ); Fri, 26 Aug 2016 15:33:11 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:36161 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751014AbcHZTdJ (ORCPT ); Fri, 26 Aug 2016 15:33:09 -0400 Date: Fri, 26 Aug 2016 22:33:04 +0300 From: Leon Romanovsky To: Christophe JAILLET Cc: matanb@mellanox.com, dledford@redhat.com, sean.hefty@intel.com, hal.rosenstock@gmail.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] IB/mlx5: Fix a parameter of find_first_bit Message-ID: <20160826193304.GH594@leon.nu> References: <1472188577-14550-1-git-send-email-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dDnEQgWzhgf+8aPe" Content-Disposition: inline In-Reply-To: <1472188577-14550-1-git-send-email-christophe.jaillet@wanadoo.fr> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --dDnEQgWzhgf+8aPe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Aug 26, 2016 at 07:16:17AM +0200, Christophe JAILLET wrote: > The 2nd parameter of 'find_first_bit' is the number of bits to search. > In this case, we are passing 'sizeof(tmp)' which is likely to be 4 or 8 > because 'tmp' is an 'unsigned long'. > > It is likely that the number of bits of 'tmp' was expected here. So use > BITS_PER_LONG instead. > > It has been spotted by the following coccinelle script: > @@ > expression ret, x; > > @@ > * ret = \(find_first_bit \| find_first_zero_bit\) (x, sizeof(...)); > > Signed-off-by: Christophe JAILLET Thanks, Acked-by: Leon Romanovsky --dDnEQgWzhgf+8aPe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXwJlwAAoJEORje4g2clin83sP/ighg72cmSuON/71UqRCpMf/ 3LYtQ1mPsrq28gIuEg8fgmiaVIcokCwxebe6W5W+z478p3+lqsjKmXGHYDUtZWxr ztMLlDj0RfPWLMfpXBshqIJFBflvfvTrwgRn60SE7+Fl7CKhAN1ng0xnKhYRC7h4 /rq0eB9qVkMCOHAnIk4Eb3ykJe8ZbdR0eCGtqEiiHFkEbe17jRtNJgeOWTw9qt62 72R3AV6RPGHLH1wv+8XuwuTVUexG/sq1bEyet4jYZqYPMu+Y/hWNWhYD/B97H/R1 Oj4MiOhWG49/zmWODqdZIx5s+k+wKMXGsbCYoVUvuHrb4qUOTVVARvI07uQG2AuK xUPlI54/UY09JI8ALK0bkFt4wYsve2yikddlQtmTvzCz2mo8Eo8sT0fObQRHQboV IM+kevxbBhHRFO+VJW2iIpYD2D+ypK3haHCC2vUstscA4zNT/ltcpqSYQBtPxzjT yOvzVh6zphq/hjcBvdhPG6YhHd+x3o5s4Vdo5LLp4K72Ygcoe1Spt5PtBIozrj4Y m4VXex2fgdSDjQx19HI0as07k8gSa4Il/uVjpGvu5ACyzjzlL3hpgi1+lNUto5b2 S8pRhb4tiYr6bsZ3sDVqw4MmRQ4/nXRllcQ7AO73GafvzmUaXN1/QBpSoLDehk8x HVGT73+FNsZjMfXE8PqJ =o4nI -----END PGP SIGNATURE----- --dDnEQgWzhgf+8aPe--