Re: [PATCH 2/2] ARM: dts: sun8i-h3: Add UART1 pinctrl

Milo Kim
2016-08-26T08:00:44Z

On 08/26/2016 04:10 PM, Maxime Ripard wrote:
>> + uart1_pins_a: uart1@0 {
>> > + allwinner,pins = "PG6", "PG7";
>> > + allwinner,function = "uart1";
>> > + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
>> > + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
>> > + };
>> > +
> Our policy is that we don't introduce new pinctrl nodes that are not
> used by any board to avoid bloating the DT too much with unused nodes.
>
> If you have a board using it, please submit that change as well.

OK, I agree.

However, this pinmux is only useful in case PA5 is assigned for PWM.
PA5 is commonly used for UART0_RX, so I'd like to add UART1 node into
*.dts and disable it (status = "disabled"). Does it make sense?

Best regards,
Milo