From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754302AbcHZXFK (ORCPT ); Fri, 26 Aug 2016 19:05:10 -0400 Received: from mail-co1nam03on0096.outbound.protection.outlook.com ([104.47.40.96]:19272 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750869AbcHZXFH (ORCPT ); Fri, 26 Aug 2016 19:05:07 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=zach.brown@ni.com; Date: Fri, 26 Aug 2016 17:29:46 -0500 From: Zach Brown To: Ulf Hansson CC: Mark Rutland , Adrian Hunter , Rob Herring , linux-mmc , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Michal Simek , =?iso-8859-1?Q?S=F6ren?= Brinkmann , "linux-arm-kernel@lists.infradead.org" , Lars-Peter Clausen Subject: Re: [PATCH 1/2] sdhci-of-arasan: Add quirk and device tree parameter to fake CD bit Message-ID: <20160826222945.GA6679@zach-desktop> References: <1472080984-17373-1-git-send-email-zach.brown@ni.com> <20160825105640.GA5439@remoulade> <20160825171539.GA13571@zach-desktop> <20160825180959.GA14705@remoulade> <20160825182621.GA14817@zach-desktop> <20160825182852.GB15000@remoulade> <20160825204645.GA19450@zach-desktop> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [130.164.62.11] X-ClientProxiedBy: YQXPR01CA0082.CANPRD01.PROD.OUTLOOK.COM (10.165.103.50) To DM2PR0401MB1454.namprd04.prod.outlook.com (10.160.222.22) X-MS-Office365-Filtering-Correlation-Id: cc220456-200e-4e40-b01b-08d3ce00847f X-Microsoft-Exchange-Diagnostics: 1;DM2PR0401MB1454;2:iZf16tsDK1ZBweoNQJRWrBEnYLdnsWlLIOQWGO0PXO96bjNOW9MCiMes8yTbVganfnf4c1v9j0aYsrWHYEIb0p/sm8VLNQKinHp8eE6PxzOzyimtyOqMD17tcILBlgL78VriudGlCHi4V9IXTDgkKoQglT3iiLGAlx6Vv5It+ijH9M4iAcb49wgrSHjC1B1/;3:uTDDG/00RJvzbBnPnXa9hsFVk0ccbm29H1O1BRbiGanXcB7+LUqFXZZNF5EryRdcyxdu5TiCQkRwKN+l/Y4RUctdZ33D90bgCGYsq+r9LQ40A7ykDmFuhIFt/etkBbOk X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0401MB1454; X-Microsoft-Exchange-Diagnostics: 1;DM2PR0401MB1454;25:9htNBXfyCm2ps8i4S5v1zFT4nQ/LP+7nmQ8IlshDUWY/XzmqAxmV3F+YNuIalyIeSbcj1is9VkOdwb7ZOxiGn6kVljEZOSsUj6satBjzJQog7c/HiFLK4en603m24xjbEkNHp4PDoTnxmQrksWBxCPVMkDyLkIZtnAKLIzGNXPfXsoLTX1rNfzq7xJOjvM/02/zc/WO3CPxFp3wcVR9nfxhgWDU6/OpBmLA0ZjXsvfJISvSFJIvLc9ZkI/8PzQzz2KbkPuNBk9fDoSXt0xY6kqmsYiFKVjec2/xkuzsS9zBKKMW5blgwow3jUBpk1iC+gVuy1mkbEbxyEvmFL19BAa2UzgwNUgkAW2shIkbaeTJcKSmpu90X25f7/99FeNUOhOiRc1e6RFl1JdGFtMehAG6PszFKx22R0uoK39soz6G+VKidYaT5t2quvdA7H0nizUEzd4op7hfSJfMHio++x77dte10DCP2//RMwvEkTEMGqUZfghM4px7ctbv41jjrHM4sD7iaQY+cV590kpFoCh42CBLqfjMRC9SonaB3AFIvi1SJF3Ibjoua8CcTwClxJBD+Aa7DNkJFEu9h/B978pJEsRSJEUeJxGbNlShpneCgV/XDgqqUXL1uWaV/bulIIYaRPPfyDRMiDaPQEQwFJp4+uJ3p+Y7o+SmdLaiaWWqoEk71xzxMMdjRiJnzAUvV2aQsb9hI7RkoIQVxLCa1SEviZuaTIXkakSi3daXpoAu0EtPM8is3zZErRtw5vfkC X-Microsoft-Exchange-Diagnostics: 1;DM2PR0401MB1454;31:PSZyZ/dEYYjTmRRvgUvV4DeriKQ4Ix4R5hKJvjMcQyxcygmVyoC0/CuAJtTqTjPC6KksdNixjJpPZDVf2b1pql9t1reJGMfSXxK9AvFjBfwDTsuqsTCkLFqPtWGthTgBPFp5b2aLJUgCNsIgZBLF0zc+KlBIsH4v+GjxWvlEPjhhyV1KZ7gdAwc1m+onV/MQNZ9P4fnvuGNPG93yz2kpUW1MQFOh/qs8dQ0LY9HrZAo=;20:gs+tb/ufsDjlj7xyq3eUa9youpnx14xzOrnA4ZBrDgis3hL1crFDBXoHctFCToDKIJmUOvHWNTKec6JOqG3O0hvpgR8kYL5W8Mj0FMSRpohc2b98XAlziESxzb16mLXX/u+UfKMeJxc7KxEKVp01k8G6majho8EZBvR6c1Hkj4CcQG64AX7JRM0Gyp9+9NJfx/X+GlmSb2nuy+yDf3FFynmcSnnnFTSOG4svBJUg8DvCnT1JC3xxqLAsrfMI+MQqVbiHX21PC/GXKOzC160f+sydhnMTkDLRp7dnLUBiCvbh3Ou148+lUGXNbOOlHwqNCxZI2OyyshRl1aHNoOWFZvnAO09IM0XqOaL8X109TjwFW9iXMGARRQM0KVv0sJcC1OJR2oXPqzqLpIP4bulk2x+QiRDzDsSI3SUOMg/bmcWcbcZbUVCPdiCUs9QMwU3Q6edORFi7PkfI1V/P8poB9Z0r/1TSL0SnYA96vzfbY9QPa5dtJAOqC6/9EcdN2vJqdybOqsjmLL6LoilwayiiG8Hpp6SI/AZxt8nFw4zJLV4X6UbVbONlaCJQErGxJYC2aAZ1rMJSNRbcunnffxXnoJfuOVBzaw52dhzmImatQ38= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(145744241990776); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:DM2PR0401MB1454;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0401MB1454; X-Microsoft-Exchange-Diagnostics: 1;DM2PR0401MB1454;4:d9ZFYT/mxJ4fH25/xyUOi//iFA+YYqenbwmlwqoKnPy94RH6dPK15Y5imInRYJLuJIEbPnOjXCqFCcXHNPYrLe+MrBHANOmAZUA4lCozwsaCN9MrIqH7g8jmaFLKTE/+D2QEBLqZzcTyt9uSMLe9aTRy4hewDNwjLybhVy5mU0ihhd52WdbUV7TjMhRlUhaHmQtwKz82xhxiJd/cL87Rw8nF5Ur2TVuO8kNqXaqpHOPEH2o6kYcRdHkOelu1AE6xK+NR1IQol8dnMKAO4nlQrA7+9tOU9rQ/zcxkrB7LwcIrgHIBmApTCj7DlTgBXCI8xGnWF1fJIkcDmfZStMHpYAuNlvmIPwlsc2NDVmkgU4sCiFaWvkJ0KQLFt0M5JbRXIDcTi8S0BscyQ9moAZrHVZ5Oi3jArUoQEfqDm9Zi0KNJdKn7EuRM3Nh1ZiBYtYsG X-Forefront-PRVS: 00462943DE X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(52314003)(51444003)(24454002)(199003)(71364002)(189002)(54356999)(586003)(101416001)(97756001)(50986999)(6116002)(76176999)(3846002)(23726003)(97736004)(19580405001)(47776003)(110136002)(66066001)(4001350100001)(92566002)(9686002)(189998001)(7736002)(33656002)(33716001)(46406003)(7846002)(1076002)(19580395003)(8666005)(7416002)(4326007)(50466002)(83506001)(68736007)(305945005)(81156014)(93886004)(2906002)(81166006)(42186005)(106356001)(230783001)(8676002)(77096005)(2950100001)(86362001)(105586002)(5660300001)(18370500001)(7059030)(107986001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM2PR0401MB1454;H:zach-desktop;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM2PR0401MB1454;23:yFqknYTU55ExzZPB4dRSF/uonHEwHOBoPNn9zYf?= =?us-ascii?Q?ZP5CrCGk8FW8v1ennbbmHJd3wJ2ptafBiIgIIRPLSWB3fSyVBofT/NJ8AHsV?= =?us-ascii?Q?8lskJ22G//fVHswBLmqUiFchVNptPJ2B/jcb9eV4Vx8Q7J3NIAjSFf1AzFjs?= =?us-ascii?Q?pDGh+uuRe8kNnpLKShTcOhEOwOqKrzS6RyS1z0OZzO0ZKzkXSpSK3GIewswk?= =?us-ascii?Q?jcr1aKEeC3TrzDwKUcVH4WJKAqwpeKLL0Y+WHAhUEViUWPqLSSR2SMVYHyCN?= =?us-ascii?Q?sU+Kk7TGrbn+W2YARNcA6GPpnnF/3MV5VfE1PfU7CGYiP/LT2V2p4bfx72sM?= =?us-ascii?Q?jtzQTuRspd0hr31KLCyaw0N1q2sYe4cSCY3y1Ki7za1X+e4bVwLE33nHpacc?= =?us-ascii?Q?z/OIKReyr9cul3LFxnmJMZJXj/q3hs5fG8xAWoqfbn2lLpryNytjxsX6k+Aq?= =?us-ascii?Q?VFYuC64n0mk3zGx9PepyHOraLcHv0ofxH2rW12OxA0Dm+GG1BlV8hZHSuSqG?= =?us-ascii?Q?+wINTN/qLESHxR5rqCGp+2EjndDNTMJt+07QxVW7ypEzo4Wo90F1mYRuuFPn?= =?us-ascii?Q?HmeHhrw+c37AvXKLuP0jZraHjju9AlzI4Gy6l//29V4BIiiKHR3VKfpAWO/h?= =?us-ascii?Q?SXqKWOYCh6GWmbHOygO8t8bi5WuE8tdn4pknDOH1hWHZscgilD/VRQNL13Up?= =?us-ascii?Q?h0AoyqX/fL2WBptk6YOXXrzV5MFktjunVHA47mRNkUtamaD9bW4j32ybVDUS?= =?us-ascii?Q?mq7Kgs/uB9GboCCEA4rdrqGJgaZZAWdUtXdjJFgWJMkr3zOFT2YBX3S8e3KU?= =?us-ascii?Q?PUwd15IyekDlyAvDJ0bGaRZogK1c08l0YAWCf2r9jwPovUf1c1KTWO/RdmZG?= =?us-ascii?Q?U7JuIyfwDJrgqHrcJzqXbx6XbQHmz0WunWbak7Eyetxj/jb28P2BDrGzX+Lo?= =?us-ascii?Q?gZFgLds1gVgyqEGzjxhFlKqnL1LhyHFoqCaruQk9139M1/Y4+GpzA3EraI+t?= =?us-ascii?Q?6dr/ova1bucNr6cRUz8JdX6dzjbLJbXQOB7jfpH0usfwIF+aAobl3LSXx9bo?= =?us-ascii?Q?kLeevs108q69cSywZ1QuWxMkbigjsVCzk6ygSRRK/fvC1SfNJ5K94vXnd2+h?= =?us-ascii?Q?pjrnHu4x34VGBczntHEIRD7/aGN/e52Y5lgMtx33yYJtCopQWyU6GGDgfExv?= =?us-ascii?Q?koxftqf7Di6cctV/Ud5tJJpC+nH3CAGdf2O4G4rHBCOqrOYsGQOZCHRTEqkj?= =?us-ascii?Q?Qg+GYMQJ7NG/bGfghozS+3tgSFE6K4vf+klk1n6xcapHpxhDEEb+ZoysSkFH?= =?us-ascii?Q?C9FBoZ0q3FI6YQuToy7F9ZsTQEze9Aoo1mIKK9/XxC6IGc+VDozRfCdyvb7e?= =?us-ascii?Q?x6fMJdA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM2PR0401MB1454;6:7SI88me4DHrWTsGaQfOzWl+zS/oGbAfFQvtA2FcHIAVjs8pksmNYtENk8cgGcxy3gIYCmsTjmUs6Lzk0fUuCA/3WtE/PbuoRNzZNs4qdB8XKdGMnWddTq+dOxYSTKWHg8RDsKMcOg6rgZNVMQRWhNLt1lqbTht34nMktPdlu1dv2l4RQvkhX5mkWhxCihrPXOvPE+iO9NKREHG+adTe9fsud9lBsFirdDkH32EthVjlnyNZCrvqMvqI7MmOuDLSE6Wqh8ARfOSOd7RvGvnuVGeHh5rKqrQEgG5T3dLJguAI=;5:5tHmY5E7rHinEuzxDgT7j6raK0vmdR9ZyvbOcwvUx+22iGP2CTkG5lheAXyBBHMkTobdGlYATMZVjid7ZcSNKPV5/a3Jw5rNNt+JU2sa1z9SQKDyh0tlIGf7IM6LHSKstkLVu843uig1EigZHY1vjQ==;24:1J2hwRNi07gbqmQEqlpvyZ16Ri7K+KusHIrRv9fQBK4MsqnHBJm2jGzmeZ/LPkX/b26ZiI/D/nsJbBcVAV2q2Jw5T+G+4Y1Xhh2eg5qf2xQ=;7:WRIMloA9gIMRzgE3Xdv5ekm3pHiksT6Wn9Zy/waD7+okMFHU9YYhI4XrRG/nJVHhPQE5axmWeNRUWeaXsg4ss43QPONHO2pmtAdDVbJXARH6jEJUzKRK1tdpsqEsgbmVch/qM7q6Cxb5mE8VJccukWB0uYHy3vYasI/5StxBgyts9x7xicktDLAw3WoSp3aIIIx7sCev8+FW3U/Bd/RkIrJGlC2OMFikB3cOKEMfZin7WzVQfaB12pFOon4LwGTK SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: ni.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2016 22:29:59.4494 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0401MB1454 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 26, 2016 at 09:42:38AM +0200, Ulf Hansson wrote: > On 25 August 2016 at 22:46, Zach Brown wrote: > > On Thu, Aug 25, 2016 at 07:28:55PM +0100, Mark Rutland wrote: > >> On Thu, Aug 25, 2016 at 01:26:22PM -0500, Zach Brown wrote: > >> > On Thu, Aug 25, 2016 at 07:10:00PM +0100, Mark Rutland wrote: > >> > > On Thu, Aug 25, 2016 at 12:15:44PM -0500, Zach Brown wrote: > >> > > > In cases where the card is non-removable then polling doesn't make sense. > >> > > > >> > > We have the non-removable property to describe that, so we can also look at that. > >> > > > >> > > > So it doesn't make sense to tie the test mode workaround into the broken-cd > >> > > > property, even though I agree the nature of the defect fits under the notion > >> > > > of the CD being broken. > >> > > > >> > > Maybe not solely on broken-cd, but I think that we dont necessarily need a new > >> > > DT property. As above, broken-cd, non-removable, and the compatible string may > >> > > together give the kernel enough information to choose the right thing to do. > >> > > > >> > > Thanks, > >> > > Mark. > >> > > >> > I'm not sure if I understand your suggestion completely. Are you suggesting > >> > setting both the broken-cd and non-removable properties? That would make sense, > >> > but my understanding was that the two properities are not meant to co-exist. In > >> > /Documentation/devicetree/bindings/mmc/mmc.txt it states that only one should > >> > be supplied. Don't the two properties conflict with each other? > >> > >> They do for the cases that exist today, but given we're updating the document > >> anyway, we could simply clarify the cases in which the two can sanely co-exist > >> (e.g. for this particular IP block). > > No, please! > > Depending on the SDHCI variant there is already some difference on how > broken-cd is treated. > > Let's not add yet another, as I think it will be too complicated for > people to understand the bindings. > Shawn Lin pointed out that there might be instances of the arasan controller that don't have the behavior the patch addresses. Having a new DT binding specific for this case would avoid needing to maintain a list of controllers that need the fix. > >> > >> Thanks, > >> Mark. > > > > That makes sense. I'll change the documentation for broken-cd and non-removable > > in the IP specific document and change the driver accordingly. > > I rather have a new DT binding specific for this case. > > Perhaps there's a better name than "fake-cd". How about "force-cd", or > if someone can come up with a better name. > > Kind regards > Uffe I've been trying to come up with a better name. Here are a few ideas cd-not-wired needs-test-cd fails-without-force-cd