From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932088AbcHZWgV (ORCPT <rfc822;w@1wt.eu>);
        Fri, 26 Aug 2016 18:36:21 -0400
Received: from mail-it0-f66.google.com ([209.85.214.66]:36691 "EHLO
        mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753133AbcHZWgT (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 26 Aug 2016 18:36:19 -0400
Date: Fri, 26 Aug 2016 18:35:51 -0400
From: Anson Jacob <ansonjacob.aj@gmail.com>
To: Andrey Utkin <andrey_utkin@fastmail.com>
Cc: gregkh@linuxfoundation.org, abbotti@mev.co.uk,
        hsweeten@visionengravers.com, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/7] staging: comedi: jr3_pci.h: Fix checkpatch warning
Message-ID: <20160826223551.GA3318@X250>
References: <cover.1472191948.git.ansonjacob.aj@gmail.com>
 <d03cc3b7c44495bce8fe7efd478d2279bccc38e2.1472191948.git.ansonjacob.aj@gmail.com>
 <20160826212358.dz4qy7ctgawyuxpa@acer>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160826212358.dz4qy7ctgawyuxpa@acer>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Aug 27, 2016 at 12:23:58AM +0300, Andrey Utkin wrote:
> On Fri, Aug 26, 2016 at 02:33:08PM -0400, Anson Jacob wrote:
> >  
> > -	/* Default_FS contains the full scale that is used if the user does */
> > -	/* not set a full scale. */
> > +	/* 
> 
> Applying: staging: comedi: jr3_pci.h: Fix checkpatch warning
> .git/rebase-apply/patch:226: trailing whitespace.
>         /* 
> warning: 1 line adds whitespace errors.
> 
> This means you have a space after asterisk. You would catch this if you run
> checkpatch.pl after making your commits.
> 
> Actually, some files you have amended, still have issues of same difficulty.
> You are encouraged to sort that out, too. See
> 
> for x in drivers/staging/comedi/drivers/cb_pcidas64.c drivers/staging/comedi/drivers/jr3_pci.c drivers/staging/comedi/drivers/jr3_pci.h drivers/staging/comedi/drivers/ni_at_a2150.c drivers/staging/comedi/drivers/ni_atmio.c drivers/staging/comedi/drivers/s626.h; do ./scripts/checkpatch.pl --strict -f $x; done

Thank you for the comments and the code snippet.

I only found one trailing whitespace issue in the patchset.

I will be uploading a new patchset with the fix for the trailing whitespace.

Are my commits are too long. Am I supposed to submit shorter ones.