From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754863AbcH0RzK (ORCPT ); Sat, 27 Aug 2016 13:55:10 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:41772 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754374AbcH0RzJ (ORCPT ); Sat, 27 Aug 2016 13:55:09 -0400 Date: Sat, 27 Aug 2016 19:54:41 +0200 From: Greg KH To: Baoyou Xie Cc: dan.carpenter@oracle.com, linux-kernel@vger.kernel.org, arnd@linaro.org, xie.baoyou@zte.com.cn Subject: Re: [PATCH] fix:memory:of_memory:add missing header dependencies Message-ID: <20160827175441.GC32072@kroah.com> References: <1472319088-18701-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1472319088-18701-1-git-send-email-baoyou.xie@linaro.org> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 28, 2016 at 01:31:28AM +0800, Baoyou Xie wrote: > We get 2 warnings when biuld kernel with W=1: Why would you do that? > drivers/memory/of_memory.c:30:30: warning: no previous prototype for 'of_get_min_tck' [-Wmissing-prototypes] > drivers/memory/of_memory.c:106:30: warning: no previous prototype for 'of_get_ddr_timings' [-Wmissing-prototypes] > > In fact, these functions are declared in drivers/memory/of_memory.h > so this patch add missing header dependencies. Why am I not seeing this warning on a "normal" build? If there's no prototype of a function, that seems odd... What about sparse, does that give you the same error here? thanks, greg k-h