From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754932AbcH0S0n (ORCPT ); Sat, 27 Aug 2016 14:26:43 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:47595 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751779AbcH0S0m (ORCPT ); Sat, 27 Aug 2016 14:26:42 -0400 Date: Sat, 27 Aug 2016 21:26:14 +0300 From: Yuval Shaia To: Baoyou Xie Cc: swise@chelsio.com, dledford@redhat.com, sean.hefty@intel.com, hal.rosenstock@gmail.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@linaro.org, xie.baoyou@zte.com.cn Subject: Re: [PATCH] fix:infiniband:hw:cxgb4:qp:mark symbols static where possible Message-ID: <20160827182613.GA3252@yuval-lap> References: <1472313618-3288-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1472313618-3288-1-git-send-email-baoyou.xie@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org One minor comment inline. Besides that: Reviewed-by: Yuval Shaia On Sun, Aug 28, 2016 at 12:00:18AM +0800, Baoyou Xie wrote: > We get 1 warning when biuld kernel with W=1: s/biuld/build > drivers/infiniband/hw/cxgb4/qp.c:686:6: warning: no previous prototype for '_free_qp' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is declared > and don't need a declaration, but can be made static. > so this patch marks it 'static'. > > Signed-off-by: Baoyou Xie > --- > drivers/infiniband/hw/cxgb4/qp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/cxgb4/qp.c b/drivers/infiniband/hw/cxgb4/qp.c > index edb1172..6904352 100644 > --- a/drivers/infiniband/hw/cxgb4/qp.c > +++ b/drivers/infiniband/hw/cxgb4/qp.c > @@ -683,7 +683,7 @@ static int build_inv_stag(union t4_wr *wqe, struct ib_send_wr *wr, > return 0; > } > > -void _free_qp(struct kref *kref) > +static void _free_qp(struct kref *kref) > { > struct c4iw_qp *qhp; > > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html