* [PATCH v2] fix:infiniband:hw:cxgb4:qp:mark symbols static where possible
@ 2016-08-28 3:29 Baoyou Xie
2016-08-28 12:49 ` Leon Romanovsky
2016-08-29 14:24 ` Steve Wise
0 siblings, 2 replies; 3+ messages in thread
From: Baoyou Xie @ 2016-08-28 3:29 UTC (permalink / raw)
To: swise, dledford, sean.hefty, hal.rosenstock
Cc: linux-rdma, linux-kernel, arnd, baoyou.xie, xie.baoyou
We get 1 warning when build kernel with W=1:
drivers/infiniband/hw/cxgb4/qp.c:686:6: warning: no previous prototype for '_free_qp' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is declared
and don't need a declaration, but can be made static.
so this patch marks it 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/infiniband/hw/cxgb4/qp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/cxgb4/qp.c b/drivers/infiniband/hw/cxgb4/qp.c
index edb1172..6904352 100644
--- a/drivers/infiniband/hw/cxgb4/qp.c
+++ b/drivers/infiniband/hw/cxgb4/qp.c
@@ -683,7 +683,7 @@ static int build_inv_stag(union t4_wr *wqe, struct ib_send_wr *wr,
return 0;
}
-void _free_qp(struct kref *kref)
+static void _free_qp(struct kref *kref)
{
struct c4iw_qp *qhp;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] fix:infiniband:hw:cxgb4:qp:mark symbols static where possible
2016-08-28 3:29 [PATCH v2] fix:infiniband:hw:cxgb4:qp:mark symbols static where possible Baoyou Xie
@ 2016-08-28 12:49 ` Leon Romanovsky
2016-08-29 14:24 ` Steve Wise
1 sibling, 0 replies; 3+ messages in thread
From: Leon Romanovsky @ 2016-08-28 12:49 UTC (permalink / raw)
To: Baoyou Xie
Cc: swise, dledford, sean.hefty, hal.rosenstock, linux-rdma,
linux-kernel, arnd, xie.baoyou
[-- Attachment #1: Type: text/plain, Size: 180 bytes --]
Except the fact that we have a little bit different format for title
==> "IB/cxgb4: Mark symbols static for _free_qp"
Looks ok,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH v2] fix:infiniband:hw:cxgb4:qp:mark symbols static where possible
2016-08-28 3:29 [PATCH v2] fix:infiniband:hw:cxgb4:qp:mark symbols static where possible Baoyou Xie
2016-08-28 12:49 ` Leon Romanovsky
@ 2016-08-29 14:24 ` Steve Wise
1 sibling, 0 replies; 3+ messages in thread
From: Steve Wise @ 2016-08-29 14:24 UTC (permalink / raw)
To: 'Baoyou Xie', dledford, sean.hefty, hal.rosenstock
Cc: linux-rdma, linux-kernel, arnd, xie.baoyou
> Subject: [PATCH v2] fix:infiniband:hw:cxgb4:qp:mark symbols static where
possible
>
Is "fix:infiniband:hw:cxgb4:qp:" some standard way patches are being submitted
these days? Usually it would be the module name, something like:
iw_cxgb4: make _free_qp() static
Steve
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-29 14:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-28 3:29 [PATCH v2] fix:infiniband:hw:cxgb4:qp:mark symbols static where possible Baoyou Xie
2016-08-28 12:49 ` Leon Romanovsky
2016-08-29 14:24 ` Steve Wise
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox