From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755616AbcH1OSM (ORCPT ); Sun, 28 Aug 2016 10:18:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34246 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755555AbcH1OSL (ORCPT ); Sun, 28 Aug 2016 10:18:11 -0400 Date: Sun, 28 Aug 2016 16:18:08 +0200 From: Jiri Olsa To: Mathieu Poirier Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, jolsa@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V6 0/5] perf: Driver specific configuration for PMU Message-ID: <20160828141808.GC32293@krava> References: <1472156445-24283-1-git-send-email-mathieu.poirier@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1472156445-24283-1-git-send-email-mathieu.poirier@linaro.org> User-Agent: Mutt/1.7.0 (2016-08-17) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Sun, 28 Aug 2016 14:18:10 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 25, 2016 at 02:20:40PM -0600, Mathieu Poirier wrote: SNIP > perf record -e some_event/@cfg1,@cfg2=config/ ... > > The above are all valid configuration and will see the strings 'cfg1' > and 'cfg2=config' sent to the PMU driver for parsing and interpretation > using the existing ioctl() mechanism. > > The primary customers for this feature are the CoreSight drivers where > the selection of a sink (where trace data is accumulated) needs to be > done in a previous, and separated step, from the launching of the perf > command. > > As such something that used to be a two-step process: > > # echo 1 > /sys/bus/coresight/devices/20070000.etr/enable_sink > # perf record -e cs_etm//u --per-thread uname > > is integrated in a single command: > > # perf record -e cs_etm/@20070000.etr/u --per-thread uname > > Thanks, > Mathieu > > Changes for V6: > - Using sysFS rather than an ioctl() to communicate command line > parameters to the CoreSight PMU. apart from few nits it looks good.. but can't say for patch 2/5 ;-) Acked-by: Jiri Olsa thanks, jirka