From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756122AbcH2GtR (ORCPT ); Mon, 29 Aug 2016 02:49:17 -0400 Received: from down.free-electrons.com ([37.187.137.238]:50883 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750738AbcH2GtQ (ORCPT ); Mon, 29 Aug 2016 02:49:16 -0400 Date: Mon, 29 Aug 2016 08:49:04 +0200 From: Maxime Ripard To: Icenowy Zheng Cc: Russell King , Chen-Yu Tsai , Hans de Goede , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v2] ARM: dts: sun8i: enable UART1 for iNet D978 Rev2 board Message-ID: <20160829064904.GB7612@lukather> References: <20160828005521.58221-1-icenowy@aosc.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jho1yZJdad60DJr+" Content-Disposition: inline In-Reply-To: <20160828005521.58221-1-icenowy@aosc.xyz> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --jho1yZJdad60DJr+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Sun, Aug 28, 2016 at 08:55:21AM +0800, Icenowy Zheng wrote: > UART1 is connected to the bluetooth part of RTL8723BS WiFi/BT combo card > on iNet D978 Rev2 board. >=20 > Enable the UART1 to make it possible to use the modified hciattach by > Realtek to drive the BT part of RTL8723BS. >=20 > On the board no r_uart pins are found now (the onboard RX/TX pins are > wired to PF2/PF4, which is muxed with mmc0), so also disabled it. >=20 > Signed-off-by: Icenowy Zheng > --- > Changes since v1: > - Deleted r_uart. > - Added the pinmux of uart1 at PG. >=20 > arch/arm/boot/dts/sun8i-a23-a33.dtsi | 14 ++++++++++++++ > arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts | 20 ++++++++++++++++++++ > 2 files changed, 34 insertions(+) >=20 > diff --git a/arch/arm/boot/dts/sun8i-a23-a33.dtsi b/arch/arm/boot/dts/sun= 8i-a23-a33.dtsi > index 7e05e09..d236104 100644 > --- a/arch/arm/boot/dts/sun8i-a23-a33.dtsi > +++ b/arch/arm/boot/dts/sun8i-a23-a33.dtsi > @@ -361,6 +361,20 @@ > allwinner,pull =3D ; > }; > =20 > + uart1_pins_a: uart1@0 { > + allwinner,pins =3D "PG6", "PG7"; > + allwinner,function =3D "uart1"; > + allwinner,drive =3D ; > + allwinner,pull =3D ; > + }; > + > + uart1_pins_cts_rts_a: uart1_cts_rts@0 { > + allwinner,pins =3D "PG8", "PG9"; > + allwinner,function =3D "uart1"; > + allwinner,drive =3D ; > + allwinner,pull =3D ; > + }; > + This should be in a different patch. > mmc0_pins_a: mmc0@0 { > allwinner,pins =3D "PF0", "PF1", "PF2", > "PF3", "PF4", "PF5"; > diff --git a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts b/arch/arm/bo= ot/dts/sun8i-a33-inet-d978-rev2.dts > index 0f52cd9..a1f654a8 100644 > --- a/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts > +++ b/arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts > @@ -49,6 +49,15 @@ > model =3D "INet-D978 Rev 02"; > compatible =3D "primux,inet-d978-rev2", "allwinner,sun8i-a33"; > =20 > + aliases { > + /delete-property/serial0; > + serial1 =3D &uart1; And to restate what I said, there's exactly *no* reason to have it a serial0. Every device in Linux is enumerated from 0 (or equivalent). The hard disks are (if you have only one, it will be /dev/sda or /dev/hda), the MMC cards are, the SPI buses are, the framebuffers are, why would the UART be a special case? Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --jho1yZJdad60DJr+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXw9rgAAoJEBx+YmzsjxAgctsQAJf+8RNehZ8Wgc5MS4Hi33QL kRSMopcu55gx+ekOMtbgBjFb2gumZkPdS+fCBTUWSh8cU603VjUPi3r81XeW/ykK U/2PU9AwcWfybxtZq2vOjEXJ0qQKbxA5Trc7K0YcGgNuxCYl0nfnEPhaR4Bichkw hOpZ0L/5cLkL4aLRgJzmau4Y23iHsv7+O1+5k8SNrVqZMUlkK+E4L6xcpuOU6v9Y AW1F0Rr+8gJyaMbGQh04Jecth+MYh98UKGTR1k6ikm0JiapsDaPA6tAQtxMFfzej rJYscdnsaEcouUk/9LrfF1g/8J7egkxxCiktMT1xyRzMekqzs2JA4ElBATYjpJZt 0MEShVCFF7I8ezE8YL2cwWTMOEDXYkmrbQqsd2a2yN/m6eMExYQlgJw9fghqcFIm OEMbpglREXjSZv8vk6BsEjB2iNtawoXYW6eyhwG5DQJ5/VIR4CwdUY561WQc2cx0 fLp8eExTTT5RH2Mms6jhdWC8l99Bwj9hrjpx5GQVSBffhK4WB7kWZteb7SBdEDtr j1gRdzZ5jzrKxGBKP9eLEdtBPUVgk4AkVNAMo5DG+uyE9EG+4IH/3qPmOCIlqAHZ GxTjNRUhddONW3T/+waAbjoYzET9qnPkHQ8galoKGVBe4AgmnULc8CYkVTJRtn6I SokGWAdGnZ6ud8F0HPYx =6Tsl -----END PGP SIGNATURE----- --jho1yZJdad60DJr+--