From: Shawn Guo <shawnguo@kernel.org>
To: Lucas Stach <l.stach@pengutronix.de>,
Yongcai Huang <anson.huang@nxp.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Fabio Estevam <fabio.estevam@nxp.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: Re: [PATCH] ARM: imx: add cpuidle support for i.mx6ul
Date: Mon, 29 Aug 2016 15:23:47 +0800 [thread overview]
Message-ID: <20160829072347.GJ30790@tiger> (raw)
In-Reply-To: <1472033090.2780.20.camel@pengutronix.de>
On Wed, Aug 24, 2016 at 12:04:50PM +0200, Lucas Stach wrote:
> Personally I would just remove the condition, but if you are concerned
> about the double L1 flush overhead (I wouldn't worry about this, it
> should be negligible) you should really make this conditional on an
> architected L2 being present. Making it conditional on the outer cache
> being absent is confusing.
Anson,
Is there any concern or problem if we follow Lucas' suggestion to
unconditionally calls flush_cache_all() here?
Shawn
next prev parent reply other threads:[~2016-08-29 7:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 16:13 [PATCH] ARM: imx: add cpuidle support for i.mx6ul Anson Huang
2016-08-24 9:08 ` Lucas Stach
2016-08-24 9:53 ` Yongcai Huang
2016-08-24 10:04 ` Lucas Stach
2016-08-24 10:13 ` Russell King - ARM Linux
2016-08-29 7:23 ` Shawn Guo [this message]
2016-08-29 7:33 ` Yongcai Huang
2016-08-25 7:08 ` Peter Chen
2016-08-26 3:33 ` Yongcai Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160829072347.GJ30790@tiger \
--to=shawnguo@kernel.org \
--cc=anson.huang@nxp.com \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox