Re: [v4.7.2: Oops] When loading IT87 HARDWARE MONITORING DRIVER

Jean Delvare
2016-08-29T10:06:39Z

Hello Alexander,

On Sat, 27 Aug 2016 18:52:42 +0300, Alexander Kapshuk wrote:
> I get an Oops when loading it87.ko on a 4.7.2 kernel. See below for details:

it87_attributes_in lacks its NULL terminator, looks suspicious to me.
Can you try the following quick fix?

---
drivers/hwmon/it87.c | 1 +
1 file changed, 1 insertion(+)

--- linux-4.7.orig/drivers/hwmon/it87.c 2016-07-04 08:01:00.000000000 +0200
+++ linux-4.7/drivers/hwmon/it87.c 2016-08-29 12:04:52.926911625 +0200
@@ -2015,6 +2015,7 @@ static struct attribute *it87_attributes
&sensor_dev_attr_in10_input.dev_attr.attr, /* 41 */
&sensor_dev_attr_in11_input.dev_attr.attr, /* 41 */
&sensor_dev_attr_in12_input.dev_attr.attr, /* 41 */
+ NULL
};

static const struct attribute_group it87_group_in = {

I'm trying to find when the bug was introduced. I have a hard time
believing it went unnoticed for long. If it fixes your problem I'll
send a clean patch.