From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757437AbcH2Nz3 (ORCPT ); Mon, 29 Aug 2016 09:55:29 -0400 Received: from gum.cmpxchg.org ([85.214.110.215]:60126 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756854AbcH2Nz2 (ORCPT ); Mon, 29 Aug 2016 09:55:28 -0400 Date: Mon, 29 Aug 2016 09:51:42 -0400 From: Johannes Weiner To: Arnd Bergmann Cc: Vladimir Davydov , Michal Hocko , Andrew Morton , Tejun Heo , Mel Gorman , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm: memcontrol: avoid unused function warning Message-ID: <20160829135142.GA2172@cmpxchg.org> References: <20160824113733.2776701-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160824113733.2776701-1-arnd@arndb.de> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 24, 2016 at 12:23:00PM +0200, Arnd Bergmann wrote: > A bugfix in v4.8-rc2 introduced a harmless warning when CONFIG_MEMCG_SWAP > is disabled but CONFIG_MEMCG is enabled: > > mm/memcontrol.c:4085:27: error: 'mem_cgroup_id_get_online' defined but not used [-Werror=unused-function] > static struct mem_cgroup *mem_cgroup_id_get_online(struct mem_cgroup *memcg) > > This moves the function inside of the #ifdef block that hides the > calling function, to avoid the warning. > > Signed-off-by: Arnd Bergmann > Fixes: 1f47b61fb407 ("mm: memcontrol: fix swap counter leak on swapout from offline cgroup") > Acked-by: Michal Hocko > Acked-by: Vladimir Davydov Acked-by: Johannes Weiner