From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756808AbcH3BG5 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 29 Aug 2016 21:06:57 -0400
Received: from mail-pf0-f194.google.com ([209.85.192.194]:34058 "EHLO
        mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753695AbcH3BG4 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 29 Aug 2016 21:06:56 -0400
Date: Tue, 30 Aug 2016 10:07:03 +0900
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>, Jan Kara <jack@suse.cz>,
        linux-kernel@vger.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCH] printk/nmi: avoid direct printk()-s from
 __printk_nmi_flush()
Message-ID: <20160830010703.GA2200@swordfish>
References: <20160829123220.1295-1-sergey.senozhatsky@gmail.com>
 <20160829151600.GM4866@pathway.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160829151600.GM4866@pathway.suse.cz>
User-Agent: Mutt/1.7.0 (2016-08-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On (08/29/16 17:16), Petr Mladek wrote:
[..]
> The comment above is not longer valid.

oh, yes. it shouldn't even be there.

> > -static void print_nmi_seq_line(struct nmi_seq_buf *s, int start, int end)
> > +static void __print_nmi_seq_line(const char *text, int len)
> 
> Also the name of the function might be confusing because it is not
> longer used only for the seq buffer. I would rename it to
> something like:
> 
>        printk_nmi_flush_line()

sounds good.

> > +static void print_nmi_seq_line(struct nmi_seq_buf *s, int start, int end)
> > +{
> 
> Then I would rename also this function to something like:
> 
>      printk_nmi_flush_seq_line()

sounds good.

> > +	const char *buf = s->buffer + start;
> > +
> > +	__print_nmi_seq_line(buf, (end - start) + 1);
> > +}
> > +
> 
> Othrewise, it looks fine. With the above suggested changes, feel
> free to add:
> 
> Reviewed-by: Petr Mladek <pmladek@suse.com>

thanks, will re-spin today.

	-ss