From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757263AbcH3Dp4 (ORCPT ); Mon, 29 Aug 2016 23:45:56 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:54643 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756417AbcH3Dpz (ORCPT ); Mon, 29 Aug 2016 23:45:55 -0400 Date: Mon, 29 Aug 2016 21:45:36 -0600 From: Jason Gunthorpe To: Jarkko Sakkinen Cc: Peter Huewe , Marcel Selhorst , "moderated list:TPM DEVICE DRIVER" , open list Subject: Re: [PATCH] tpm: fix invalid constant expressions in tpm.h Message-ID: <20160830034536.GA29261@obsidianresearch.com> References: <1472520498-24173-1-git-send-email-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1472520498-24173-1-git-send-email-jarkko.sakkinen@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 30, 2016 at 04:28:17AM +0300, Jarkko Sakkinen wrote: > The enums tpm_capabilities and tpm_sub_capabilities do not contain legit > constant expressions. This commit makes cap_id a separate parameter > in I wonder if this is a bug in sparse? the macro uses gcc magic to expand to a constexpr. You could also use __constant_cpu_to_be32 and similar instead. But I admit I never liked the use of no-host endian in the constants.. > #define TPM_ORD_STARTUP cpu_to_be32(153) > #define TPM_ST_CLEAR cpu_to_be16(1) Would be nice to see these fixed into an enum someday too > +enum tpm1_capabilities { > + TPM1_CAP_FLAG = 0x04, > + TPM1_CAP_PROP = 0x05, > + TPM1_CAP_VERSION_1_1 = 0x06, > + TPM1_CAP_VERSION_1_2 = 0x1A, I usually discourage the extra horizontal whitespace, just causes patch churn to keep it up (and clang-format won't do it automatically). Not sure if there is a consensus on that though. But looks fine to me. Reviewed-by: Jason Gunthorpe Jason