From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758022AbcH3KAM (ORCPT ); Tue, 30 Aug 2016 06:00:12 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:37061 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757502AbcH3KAD (ORCPT ); Tue, 30 Aug 2016 06:00:03 -0400 Date: Tue, 30 Aug 2016 11:01:48 +0100 From: Lee Jones To: Peter Griffin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, vinod.koul@intel.com, patrice.chotard@st.com, dan.j.williams@intel.com, airlied@linux.ie, kraxel@redhat.com, ohad@wizery.com, bjorn.andersson@linaro.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-remoteproc@vger.kernel.org, Arnaud Pouliquen Subject: Re: [PATCH v8 15/18] ARM: STi: DT: STiH407: Add uniperif reader dt nodes Message-ID: <20160830100148.GO1661@dell> References: <1472223413-7254-1-git-send-email-peter.griffin@linaro.org> <1472223413-7254-16-git-send-email-peter.griffin@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1472223413-7254-16-git-send-email-peter.griffin@linaro.org> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 26 Aug 2016, Peter Griffin wrote: > This patch adds the DT node for the uniperif reader > IP block found on STiH407 family silicon. > > Signed-off-by: Arnaud Pouliquen > Signed-off-by: Peter Griffin > --- > arch/arm/boot/dts/stih407-family.dtsi | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi > index d263c96..bdddf2c 100644 > --- a/arch/arm/boot/dts/stih407-family.dtsi > +++ b/arch/arm/boot/dts/stih407-family.dtsi > @@ -956,5 +956,31 @@ > st,version = <5>; > st,mode = "SPDIF"; > }; > + > + sti_uni_reader0: sti-uni-reader@0 { > + compatible = "st,sti-uni-reader"; > + status = "disabled"; I find it's normally nicer to place the status of the node at the bottom, separated by a '\n'. There isn't a functional difference admittedly, but it would be my preference, since it's not describing the device per se. > + #sound-dai-cells = <0>; > + st,syscfg = <&syscfg_core>; > + reg = <0x8D83000 0x158>; We usually use lower-case for the address. Since this has a 'reg' property, the '0' in the node name does not look appropriate. > + interrupts = ; > + dmas = <&fdma0 5 0 1>; > + dma-names = "rx"; > + dai-name = "Uni Reader #0 (PCM IN)"; Oooo, not seen something like this before. If it does not already have one, it would require a DT Ack. > + st,version = <3>; This will likely need a DT Ack too. We usually encode this sort of information in the compatible string. > + }; > + > + sti_uni_reader1: sti-uni-reader@1 { > + compatible = "st,sti-uni-reader"; > + status = "disabled"; > + #sound-dai-cells = <0>; > + st,syscfg = <&syscfg_core>; > + reg = <0x8D84000 0x158>; > + interrupts = ; > + dmas = <&fdma0 6 0 1>; > + dma-names = "rx"; > + dai-name = "Uni Reader #1 (HDMI RX)"; > + st,version = <3>; > + }; All as above. > }; > }; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog