From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754736AbcH3OiE (ORCPT <rfc822;w@1wt.eu>);
        Tue, 30 Aug 2016 10:38:04 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59150 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754590AbcH3OiB (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 30 Aug 2016 10:38:01 -0400
Date: Tue, 30 Aug 2016 16:37:28 +0200
From: Oleg Nesterov <oleg@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Dmitry Safonov <dsafonov@virtuozzo.com>, linux-kernel@vger.kernel.org,
        mingo@redhat.com, luto@amacapital.net, tglx@linutronix.de,
        hpa@zytor.com, x86@kernel.org, 0x7f454c46@gmail.com,
        viro@zeniv.linux.org.uk
Subject: Re: [RFC 2/3] uprobe: drop isdigit() check in create_trace_uprobe
Message-ID: <20160830143727.GB23007@redhat.com>
References: <20160825152110.25663-1-dsafonov@virtuozzo.com> <20160825152110.25663-3-dsafonov@virtuozzo.com> <20160829185813.6d044a8e@gandalf.local.home> <20160829185917.170e8aad@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160829185917.170e8aad@gandalf.local.home>
User-Agent: Mutt/1.5.18 (2008-05-17)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 30 Aug 2016 14:38:01 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 08/29, Steven Rostedt wrote:
>
> On Mon, 29 Aug 2016 18:58:13 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > On Thu, 25 Aug 2016 18:21:09 +0300
> > Dmitry Safonov <dsafonov@virtuozzo.com> wrote:
> >
> > > It's useless. Before:
> > >   [tracing]# echo 'p:test /a:0x0' >> uprobe_events
> > >   [tracing]# echo 'p:test a:0x0' >> uprobe_events
> > >   -bash: echo: write error: No such file or directory
> > >   [tracing]# echo 'p:test 1:0x0' >> uprobe_events
> > >   -bash: echo: write error: Invalid argument
> > > 
> > > After:
> > >   [tracing]# echo 'p:test 1:0x0' >> uprobe_events
> > >   -bash: echo: write error: No such file or directory
> > > 
> > > Signed-off-by: Dmitry Safonov <dsafonov@virtuozzo.com>  
> > 
> > Acked-by: Steven Rostedt <rostedt@goodmis.org>
>
> Actually, this patch seems agnostic to the series. I'll just pull it in
> now.

Yes, agreed, this isdigit() is pointless, thanks.

Oleg.