From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754858AbcH3O6T (ORCPT ); Tue, 30 Aug 2016 10:58:19 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:42950 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753592AbcH3O6R (ORCPT ); Tue, 30 Aug 2016 10:58:17 -0400 X-IBM-Helo: d28dlp03.in.ibm.com X-IBM-MailFrom: srikar@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Date: Tue, 30 Aug 2016 20:27:56 +0530 From: Srikar Dronamraju To: Steven Rostedt Cc: Dmitry Safonov , linux-kernel@vger.kernel.org, mingo@redhat.com, luto@amacapital.net, tglx@linutronix.de, hpa@zytor.com, x86@kernel.org, 0x7f454c46@gmail.com, oleg@redhat.com, viro@zeniv.linux.org.uk Subject: Re: [RFC 2/3] uprobe: drop isdigit() check in create_trace_uprobe Reply-To: Srikar Dronamraju References: <20160825152110.25663-1-dsafonov@virtuozzo.com> <20160825152110.25663-3-dsafonov@virtuozzo.com> <20160829185813.6d044a8e@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20160829185813.6d044a8e@gandalf.local.home> User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16083014-0016-0000-0000-0000030FA66E X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16083014-0017-0000-0000-000025D4E1F6 Message-Id: <20160830145756.GA2471@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-30_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608300144 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Steven Rostedt [2016-08-29 18:58:13]: > On Thu, 25 Aug 2016 18:21:09 +0300 > Dmitry Safonov wrote: > > > It's useless. Before: > > [tracing]# echo 'p:test /a:0x0' >> uprobe_events > > [tracing]# echo 'p:test a:0x0' >> uprobe_events > > -bash: echo: write error: No such file or directory > > [tracing]# echo 'p:test 1:0x0' >> uprobe_events > > -bash: echo: write error: Invalid argument > > > > After: > > [tracing]# echo 'p:test 1:0x0' >> uprobe_events > > -bash: echo: write error: No such file or directory > > > > Signed-off-by: Dmitry Safonov > > Acked-by: Steven Rostedt Agree. Acked-by: Srikar Dronamraju -- Thanks and Regards Srikar Dronamraju